Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758324AbaGPIWi (ORCPT ); Wed, 16 Jul 2014 04:22:38 -0400 Received: from www.linutronix.de ([62.245.132.108]:53875 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbaGPIWe (ORCPT ); Wed, 16 Jul 2014 04:22:34 -0400 Message-ID: <53C63642.7080208@linutronix.de> Date: Wed, 16 Jul 2014 10:22:26 +0200 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: Olivier Galibert CC: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren , Felipe Balbi , Linux Kernel Mailing List , linux-serial@vger.kernel.org Subject: Re: [PATCH 1/6] tty: serial: 8250 core: provide a function to export uart_8250_port References: <1404928177-26554-1-git-send-email-bigeasy@linutronix.de> <1404928177-26554-2-git-send-email-bigeasy@linutronix.de> In-Reply-To: X-Enigmail-Version: 1.6+git0.20140323 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/10/2014 04:30 PM, Olivier Galibert wrote: > On Wed, Jul 9, 2014 at 7:49 PM, Sebastian Andrzej Siewior > wrote: >> + * The lock assumption made here is none because runtime-pm suspend/resume >> + * callbacks should not be invoked there is any operation performed on the port. > > I think there's a missing "if"? Thanks, fixed up. > Best, > > OG. > Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/