Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754596AbaGPJZu (ORCPT ); Wed, 16 Jul 2014 05:25:50 -0400 Received: from top.free-electrons.com ([176.31.233.9]:33253 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752547AbaGPJZp (ORCPT ); Wed, 16 Jul 2014 05:25:45 -0400 Date: Wed, 16 Jul 2014 11:25:41 +0200 From: Antoine =?iso-8859-1?Q?T=E9nart?= To: Varka Bhadram Cc: Antoine =?iso-8859-1?Q?T=E9nart?= , sebastian.hesselbarth@gmail.com, Peter.Chen@freescale.com, balbi@ti.com, p.zabel@pengutronix.de, alexandre.belloni@free-electrons.com, thomas.petazzoni@free-electrons.com, zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver Message-ID: <20140716092541.GC28151@kwain> References: <1405499166-6726-1-git-send-email-antoine.tenart@free-electrons.com> <1405499166-6726-6-git-send-email-antoine.tenart@free-electrons.com> <53C64389.3050705@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <53C64389.3050705@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: > On 07/16/2014 01:55 PM, Antoine T?nart wrote: > >+static const struct of_device_id phy_berlin_sata_of_match[] = { > >+ { > >+ .compatible = "marvell,berlin2-usb-phy", > >+ .data = &phy_berlin_pll_dividers[0], > >+ }, > >+ { > >+ .compatible = "marvell,berlin2cd-usb-phy", > >+ .data = &phy_berlin_pll_dividers[1], > >+ }, > >+ { }, > >+}; > >+MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match); > >+ > > It looks good if we move this after probe().. So that we can see of_match_table directly... We use the of match table in the probe, when calling of_match_device(). > >+static int phy_berlin_usb_probe(struct platform_device *pdev) > >+{ > >+ const struct of_device_id *match = > >+ of_match_device(phy_berlin_sata_of_match, &pdev->dev); Here. Antoine > >+ struct phy_berlin_usb_priv *priv; > >+ struct resource *res; > >+ struct phy_provider *phy_provider; > >+ > >+ priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > >+ if (!priv) > >+ return -ENOMEM; > >+ > >+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >+ priv->base = devm_ioremap_resource(&pdev->dev, res); > >+ if (IS_ERR(priv->base)) > >+ return PTR_ERR(priv->base); > >+ > >+ priv->rst_ctrl = devm_reset_control_get(&pdev->dev, NULL); > >+ if (IS_ERR(priv->rst_ctrl)) > >+ return PTR_ERR(priv->rst_ctrl); > >+ > >+ priv->pll_divider = *((u32 *)match->data); > >+ > >+ priv->phy = devm_phy_create(&pdev->dev, &phy_berlin_usb_ops, NULL); > >+ if (IS_ERR(priv->phy)) { > >+ dev_err(&pdev->dev, "failed to create PHY\n"); > >+ return PTR_ERR(priv->phy); > >+ } > >+ > >+ platform_set_drvdata(pdev, priv); > >+ > >+ phy_provider = > >+ devm_of_phy_provider_register(&pdev->dev, of_phy_simple_xlate); > >+ if (IS_ERR(phy_provider)) > >+ return PTR_ERR(phy_provider); > >+ > >+ return 0; > >+} -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/