Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755531AbaGPJ0X (ORCPT ); Wed, 16 Jul 2014 05:26:23 -0400 Received: from mail-oa0-f52.google.com ([209.85.219.52]:34301 "EHLO mail-oa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754897AbaGPJ0T (ORCPT ); Wed, 16 Jul 2014 05:26:19 -0400 MIME-Version: 1.0 In-Reply-To: <20140715235058.GB32651@kroah.com> References: <20140715091144.GA19080@devel.8.8.4.4> <20140715152929.GA8844@kroah.com> <20140715235058.GB32651@kroah.com> Date: Wed, 16 Jul 2014 18:26:17 +0900 Message-ID: Subject: Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err() From: DaeSeok Youn To: Greg KH Cc: Lidza Louina , devel , driverdev-devel@linuxdriverproject.org, linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-07-16 8:50 GMT+09:00 Greg KH : > On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote: >> Hi, >> >> 2014-07-16 0:29 GMT+09:00 Greg KH : >> > On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote: >> >> The dgap_err() is printing a message with pr_err(), >> >> so all those are replaced. >> >> >> >> Use definition "pr_fmt" and then all of "dgap:" in >> >> the beginning of print messages are removed. >> >> >> >> And also removed "out of memory" message because >> >> the kernel has own message for that. >> >> >> >> Signed-off-by: Daeseok Youn >> >> --- >> >> V2: use pr_fmt "dgap:" prefix on print message on dgap. >> >> remove "out of memory" message. >> >> >> >> Adds Mark to TO list and CC list for checking send >> >> this email properly to him. >> >> >> >> drivers/staging/dgap/dgap.c | 306 +++++++++++++++++++------------------------ >> >> 1 files changed, 133 insertions(+), 173 deletions(-) >> >> >> >> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c >> >> index 06c55cb..9e750fb 100644 >> >> --- a/drivers/staging/dgap/dgap.c >> >> +++ b/drivers/staging/dgap/dgap.c >> >> @@ -41,6 +41,8 @@ >> >> */ >> >> #undef DIGI_CONCENTRATORS_SUPPORTED >> >> >> >> +#define pr_fmt(fmt) "dgap: " fmt >> >> + >> >> #include >> >> #include >> >> #include >> >> @@ -153,7 +155,6 @@ static void dgap_firmware_reset_port(struct channel_t *ch); >> >> static int dgap_gettok(char **in); >> >> static char *dgap_getword(char **in); >> >> static int dgap_checknode(struct cnode *p); >> >> -static void dgap_err(char *s); >> >> >> >> /* >> >> * Function prototypes from dgap_sysfs.h >> >> @@ -815,7 +816,7 @@ static struct board_t *dgap_found_board(struct pci_dev *pdev, int id, >> >> if (ret) >> >> goto free_brd; >> >> >> >> - pr_info("dgap: board %d: %s (rev %d), irq %ld\n", >> >> + pr_info("board %d: %s (rev %d), irq %ld\n", >> >> boardnum, brd->name, brd->rev, brd->irq); >> > >> > Almost all of the pr_*() calls in this driver should be converted over >> > to use dev_*() calls instead. And some of them, like this one, should >> > be removed entirely (no need for a driver to be "noisy" when a device >> > for it is found, it should be quiet if at all possible, unless something >> > went wrong.) >> > >> > So can you do that here instead? I've applied the earlier patches in >> > this series, and stopped here. >> OK. I can. pr_*() calls are replaced with dev_*() calls. >> And also removes some of print message which are useless like "out >> of memory" > > Yes, please do that, that would be great. I have been working to change pr_*() to dev_*(), but dgap_parse() has no "struct device" for using dev_*(). If dgap_parse still need for this driver, it need to take a parameter for using dev_*(), it may be "pdev" but configuration file doesn't need to parse in kernel at all, dgap_parse() will be removed. So I will wait to verify by Mark about parsing configuration file. Thanks. regards, Daeseok Youn. > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/