Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759126AbaGPLAt (ORCPT ); Wed, 16 Jul 2014 07:00:49 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40053 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756409AbaGPLAq (ORCPT ); Wed, 16 Jul 2014 07:00:46 -0400 Date: Wed, 16 Jul 2014 12:00:12 +0100 From: Mark Brown To: Thierry Reding Cc: Tuomas Tynkkynen , Andrew Bresticker , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , Prashant Gaikwad , Mike Turquette , Stephen Warren , Viresh Kumar , Peter De Schrijver , "Rafael J. Wysocki" Message-ID: <20140716110012.GL17528@sirena.org.uk> References: <53C01558.3090607@nvidia.com> <53C01D17.2050906@nvidia.com> <20140714083854.GO2081@ulmo> <20140714091233.GC6800@sirena.org.uk> <20140714092434.GA9755@ulmo> <20140714102203.GD6800@sirena.org.uk> <53C58DCB.90502@nvidia.com> <20140715225252.GD17528@sirena.org.uk> <20140716080133.GI7978@ulmo> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+PbGPm1eXpwOoWkI" Content-Disposition: inline In-Reply-To: <20140716080133.GI7978@ulmo> X-Cookie: 98% lean. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 01/13] clk: tegra: Add binding for the Tegra124 DFLL clocksource X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+PbGPm1eXpwOoWkI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 16, 2014 at 10:01:34AM +0200, Thierry Reding wrote: > On Tue, Jul 15, 2014 at 11:52:52PM +0100, Mark Brown wrote: > > This looks fine, can you submit properly please? For the I2C address > > why not just have an interface to get the regmap and then provide a way > > to get the underlying device back from the regmap? > Is it mandatory for regulators to use regmap? Also I'm not sure how this No, but this is for a limited subset of devices that the hardware knows how to write to directly which means that they're restricted to things that can be supported with regmap (or already know how to interact with the hardware and don't need this interface at all). The proposed patch already relies on regmap - it's passing back the information the regmap helpers use. > will work with MFDs, since the device may not be the actual bus device, > but rather a child of the MFD (and what we want access to is the MFD). > Perhaps for regmaps that would work in most cases since MFDs seem to > aften share the regmap with their children. However, the code in > regulator_register() at least indicates that even then it's possible to > have a regmap in children that's different from the top-level MFD. Right, drivers can say exactly which regmap to use. --+PbGPm1eXpwOoWkI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTxls5AAoJELSic+t+oim9vC0P/1ga+B2y7WfWBEoc0bRFCC2W UO0bq9GC1ygvBdsDGjqMzxAUQdJjk0wgjTe3ZgY+suhiUbE+YgH/bXdh1HI40pbP n3oW32wBKgxuaqmrn1aitm/owiD96nzhK3aWb458EoRFQ1XpvRfmiON1By31Yorx wkoVWG1TK3D82GNLrqyXBprgFFABQS9DI3gg7nrFICv2v4wGzrAK/xUFZbBjyFuY vcZRy4fhmGx+lEd1pr2MNnynwD4acLSjQuqdWddLvrR8fu4kuKbMijZOWY251Yq+ 4oyTJ7yPhNc4uuNDSYNbX4RiKsecOEPaqixLsBYJWZrlw/KOeLbkPCWqZA+bfIJ7 sBtwC8+lgfarYtztcIZtJe9wkXLM4TW4w+17OrrjhhK2ACF116pyTF91sPdFeKTl AuUGoqnyTvdW+o+aOFvVE2nCICJCLMErP4qOQjzl/6UnvNfsG0Ws8gjnChKEWkDS oVNHc9lUuN5/njQURrc+EJno/N4n4qTE15T5Atn5bFjpKHvQgt+REKWd0GtEVKJR Un0b3PAgEBRzARd1XBXROMEzc2TokimTDFXpaZXw2vdjw2eO4lSfVvV4FEQjMCHh 3OmJ9WnTxeCd/lmsQk5JagEOqYTWZE1x1Ur7P3mali7VzDRC85mGFF6uOxYkgMKY A/Oihci0OXH8pNi2lC+n =ebZh -----END PGP SIGNATURE----- --+PbGPm1eXpwOoWkI-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/