Message-id: <53C66924.3010303@samsung.com>
Date: Wed, 16 Jul 2014 13:59:32 +0200
From: Tomasz Figa <t.figa@samsung.com>
Organization: Samsung R&D Institute Poland
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101
 Thunderbird/24.5.0
MIME-version: 1.0
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Russell King <linux@arm.linux.org.uk>,
        Kukjin Kim <kgene.kim@samsung.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Sachin Kamat <sachin.kamat@samsung.com>,
        Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v2] ARM: EXYNOS: Fix build with PM_SLEEP=n
References: <1405323953-25954-1-git-send-email-k.kozlowski@samsung.com>
In-reply-to: <1405323953-25954-1-git-send-email-k.kozlowski@samsung.com>
Content-type: text/plain; charset=ISO-8859-1
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

Hi Krzysztof,

On 14.07.2014 09:45, Krzysztof Kozlowski wrote:
> Fix building of exynos defconfig with disabled PM_SLEEP:
> CONFIG_PM_SLEEP=n
> CONFIG_PM_SLEEP_SMP=n
> CONFIG_SUSPEND=n
> by moving functions for power up/down of CPU and cluster to platsmp.c
> 
> The build error messages:
> arch/arm/mach-exynos/built-in.o: In function `exynos_boot_secondary':
> arch/arm/mach-exynos/platsmp.c:111: undefined reference to `exynos_cpu_power_state'
> arch/arm/mach-exynos/platsmp.c:112: undefined reference to `exynos_cpu_power_up'
> arch/arm/mach-exynos/platsmp.c:116: undefined reference to `exynos_cpu_power_state'
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> ---
> Changes since v1:
> 1. Use different solution - just move the power up/down functions to a
>    common place instead of adding stubs in common.h. Suggested by Tomasz
>    Figa.
> ---
>  arch/arm/mach-exynos/platsmp.c | 66 ++++++++++++++++++++++++++++++++++++++++++
>  arch/arm/mach-exynos/pm.c      | 66 ------------------------------------------
>  2 files changed, 66 insertions(+), 66 deletions(-)
> 

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

--
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/