Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965356AbaGPOrr (ORCPT ); Wed, 16 Jul 2014 10:47:47 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:54466 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965284AbaGPOrl (ORCPT ); Wed, 16 Jul 2014 10:47:41 -0400 Date: Wed, 16 Jul 2014 09:46:28 -0500 From: Felipe Balbi To: Vivek Gautam CC: , , , , , , , , , , , Subject: Re: [PATCH v4 2/4] usb: host: xhci-plat: Get PHYs for xhci's hcds Message-ID: <20140716144628.GC1365@saruman.home> Reply-To: References: <1405498900-13473-1-git-send-email-gautam.vivek@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tqI+Z3u+9OQ7kwn0" Content-Disposition: inline In-Reply-To: <1405498900-13473-1-git-send-email-gautam.vivek@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tqI+Z3u+9OQ7kwn0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 16, 2014 at 01:51:40PM +0530, Vivek Gautam wrote: > The host controller by itself may sometimes need to handle PHY > and/or calibrate some of the PHY settings to get full support out > of the PHY controller. The PHY core provides a calibration > funtionality now to do so. > Therefore, facilitate getting the two possible PHYs, viz. > USB 2.0 type (UTMI+) and USB 3.0 type (PIPE3). >=20 > Signed-off-by: Vivek Gautam > --- >=20 > Changes from v3: > - Modified error message as per review comments from Julius. >=20 > drivers/usb/host/xhci-plat.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > index 1a0cf9f..b1c0364 100644 > --- a/drivers/usb/host/xhci-plat.c > +++ b/drivers/usb/host/xhci-plat.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > =20 > @@ -180,6 +181,15 @@ static int xhci_plat_probe(struct platform_device *p= dev) > goto put_hcd; > } > =20 > + /* Get possile USB 2.0 type PHY (UTMI+) available with xhci */ > + hcd->gen_phy =3D devm_phy_get(&pdev->dev, "usb2-phy"); > + if (IS_ERR(hcd->gen_phy)) { > + ret =3D PTR_ERR(hcd->gen_phy); > + if (ret !=3D -ENOSYS && ret !=3D -ENODEV) > + dev_warn(&pdev->dev, > + "Error retrieving usb2 phy: %d\n", ret); > + } should you treat -EPROBE_DEFER differently here ? --=20 balbi --tqI+Z3u+9OQ7kwn0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJTxpBEAAoJEIaOsuA1yqREx1wP/iNhqLpglq0SZRPjO4LozUUv +09YZ5L5kjzUacYi9Brqw8nADLB2wmdujfHrF0ezB/VqduFpP/i+XAfhQx2ZkaFR Pp9qclEAetygR393laychLfeOS06mMgzUH1/+LOfjNaqLy8Tg1e9bAnaK2ON0lIj b3Fh+fbStuNUvTbRR4pTVvhTJnB5Dv7oUHPnRJuMgEE1zJyX47r9HPPDg3jlnExM 8AB6rwXO8cBwj4ugDk2hm91w/jPL/wydCETvxQNGku5fgKztxF1zsBnvUcWjhpro n38nfLYkBXQOCCpPnrjH+yxWCRIHIiy1jZ/EqfwmKlq09JbCPIemHgPOpO9E3fiH C8DsL03jNQZZZKbFeGpBeJg3uldlTjO7yInIa7poqfeeH3PKzWtSP2YQz6O9z1nR nHlYvVIJTy9ir9edTPfqU2JzPXoMxrofZbyKGyBo4R6yRe80IxvQe7CLtNvGcNno OhpwnRLZFeVUtiCBriGFFn6N+jxE4eyttZ/w/0c/dFSY6goJwXaSa+cIld04V7aj R2MBQAJdIOQguOj2HHD1D6EXne5gMC0dbcVCzu2AV5tmgWxrLIHaifChwOkCTn6k 5aqtMqcH2R4WFSjlUV4JPzJZH8UojIkd+nc566XKN6hiT+BzBF+Cerd74JaDi1MZ a+70M9jNuM9CtMnWH7X7 =FRfZ -----END PGP SIGNATURE----- --tqI+Z3u+9OQ7kwn0-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/