Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965588AbaGPQ0i (ORCPT ); Wed, 16 Jul 2014 12:26:38 -0400 Received: from mx0.aculab.com ([213.249.233.131]:58422 "HELO mx0.aculab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S934509AbaGPQ0e convert rfc822-to-8bit (ORCPT ); Wed, 16 Jul 2014 12:26:34 -0400 From: David Laight To: "'Will Deacon'" , Zi Shen Lim CC: Catalin Marinas , Jiang Liu , AKASHI Takahiro , "David S. Miller" , Daniel Borkmann , "Alexei Starovoitov" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" Subject: RE: [PATCH RFCv3 08/14] arm64: introduce aarch64_insn_gen_movewide() Thread-Topic: [PATCH RFCv3 08/14] arm64: introduce aarch64_insn_gen_movewide() Thread-Index: AQHPoRFpbJyMz3fig0KZk4udHJrU0pui4nQA Date: Wed, 16 Jul 2014 16:25:35 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D17274D55@AcuExch.aculab.com> References: <1405405512-4423-1-git-send-email-zlim.lnx@gmail.com> <1405405512-4423-9-git-send-email-zlim.lnx@gmail.com> <20140716161715.GU29414@arm.com> In-Reply-To: <20140716161715.GU29414@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Will Deacon ... > > + BUG_ON(imm < 0 || imm > 65535); > > Do this check with masking instead? The compiler will convert that to a single unsigned comparison. ... > > + BUG_ON(shift != 0 && shift != 16 && shift != 32 && > > + shift != 48); OTOH I don't think it will convert that to: BUG_ON(shift & ~48); David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/