Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934760AbaGPRzP (ORCPT ); Wed, 16 Jul 2014 13:55:15 -0400 Received: from smtprelay0082.hostedemail.com ([216.40.44.82]:55541 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932418AbaGPRzM (ORCPT ); Wed, 16 Jul 2014 13:55:12 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:69:355:379:541:599:967:973:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2828:2859:2907:2909:2911:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3354:3865:3866:3867:3868:3870:3871:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4425:5007:6119:7652:7903:9025:9072:9388:10004:10049:10400:10848:11026:11232:11658:11914:12043:12296:12517:12519:12683:12740:13019:13069:13076:13095:13138:13231:13311:13357:13618:14095:14096:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn X-HE-Tag: hope85_2cdebd1b4fd1c X-Filterd-Recvd-Size: 2839 Message-ID: <1405533306.6381.4.camel@joe-AO725> Subject: Re: [PATCH 0/4] printk: start simplifying some flags From: Joe Perches To: Alex Elder , "kay.sievers" Cc: akpm@linux-foundation.org, pmladek@suse.cz, bp@suse.de, john.stultz@linaro.org, jack@suse.cz, linux-kernel@vger.kernel.org Date: Wed, 16 Jul 2014 10:55:06 -0700 In-Reply-To: <1405531620-9983-1-git-send-email-elder@linaro.org> References: <1405531620-9983-1-git-send-email-elder@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (adding Kay Sievers) On Wed, 2014-07-16 at 12:26 -0500, Alex Elder wrote: > Each log record has a "flags" field. The flags keep track of, for > instance, whether the record was saved in its entirety (as opposed > to being one of multiple records that should be merged as a single > unit). A log record's flags field alone is not currently sufficient > to know how the record should be formatted; you need to know the > previous record's flags field as well. I found understanding the > real effect of various combinations of these flags to be very > difficult, and was moved to try to do something about that. > > This series includes three patches that begin the process of > simplifying how these flags are used and interpreted. They include > very long, detailed explanations (as small patches often do) because > I want my reasoning to be very clear and examined very closely. I > really don't want to break printk()... > > The first patch simplifies some code based on the observation that > certain flag combinations never occur. > > The second and third patch fix what I assert is a bug in two places. > The bug is that a LOG_PREFIX in a message should implicitly > terminate its predecessor, even if the predecessor was marked > LOG_CONT. I would really like to have someone else confirm > they agree my assertion here. > > One trivial extra patch is included at the end of the series. > > -Alex > > This series, based on v3.16-rc4, is available here: > http://git.linaro.org/landing-teams/working/broadcom/kernel.git > Branch review/printk-flags > > Alex Elder (4): > printk: LOG_CONT and LOG_NEWLINE are separate > printk: honor LOG_PREFIX in devkmsg_read() > printk: honor LOG_PREFIX in msg_print_text() > printk: correct some more typos > > kernel/printk/printk.c | 40 ++++++++++++++++++---------------------- > 1 file changed, 18 insertions(+), 22 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/