Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753831AbaGPWSe (ORCPT ); Wed, 16 Jul 2014 18:18:34 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:47634 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752554AbaGPWSb (ORCPT ); Wed, 16 Jul 2014 18:18:31 -0400 Date: Wed, 16 Jul 2014 15:18:23 -0700 From: Zi Shen Lim To: Will Deacon Cc: Catalin Marinas , Jiang Liu , AKASHI Takahiro , "David S. Miller" , Daniel Borkmann , Alexei Starovoitov , Chema Gonzalez , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH RFCv3 00/14] arm64: eBPF JIT compiler Message-ID: <20140716221823.GA3378@gup76> References: <1405405512-4423-1-git-send-email-zlim.lnx@gmail.com> <20140716104153.GL29414@arm.com> <20140716162146.GV29414@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140716162146.GV29414@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 16, 2014 at 05:21:47PM +0100, Will Deacon wrote: > On Wed, Jul 16, 2014 at 11:41:53AM +0100, Will Deacon wrote: > > On Tue, Jul 15, 2014 at 07:24:58AM +0100, Zi Shen Lim wrote: > > > This series implements eBPF JIT compiler for arm64. > > > See [14/14] for change log. > > > > > > Patches [1-13/14] implement code generation functions. > > > > Nice work, I'll take a look. Thanks! > > ... and it all looks pretty damn good to me. I gave you a few in-line Thanks :) > comments but, rather than repeat myself for each patch, my main two gripes > were: > > - The use of BUG_ON all over the place I responded to your comment about BUG_ON in [1/14]. > > - Explicit limit checks which could be done with masks I responded to your comment about this in [8/14]. I can go ahead and make changes throughout if you prefer. > > If you address those, this stuff looks pretty much ready to go from my > perspective. Do you have a branch somewhere I can play with please? Just pushed it to: https://github.com/zlim/linux.git arm64/bpf which is the same as this RFCv3 series, i.e. I haven't rebased it on latest net-next. Thanks so much for your time and attention! Let me know how it goes for you. I can post this series (dropping RFC) once we finalized the above. Cheers, z -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/