Message-ID: <1405556384.6381.23.camel@joe-AO725>
Subject: Re: [PATCH] staging: gdm72xx: conditionally compile debug code
From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Michalis Pappas <mpappas@fastmail.fm>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Wed, 16 Jul 2014 17:19:44 -0700
In-Reply-To: <20140716225742.GA2983@kroah.com>
References: <1404219616-1788-1-git-send-email-mpappas@fastmail.fm>
	 <1404219616-1788-2-git-send-email-mpappas@fastmail.fm>
	 <20140709185142.GA13271@kroah.com> <53C6E332.2070301@fastmail.fm>
	 <20140716205024.GA11078@kroah.com> <53C6F69A.5070108@fastmail.fm>
	 <20140716221034.GB716@kroah.com> <1405550769.6381.17.camel@joe-AO725>
	 <20140716225742.GA2983@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Wed, 2014-07-16 at 15:57 -0700, Greg KH wrote:
> On Wed, Jul 16, 2014 at 03:46:09PM -0700, Joe Perches wrote:
> > On Wed, 2014-07-16 at 15:10 -0700, Greg KH wrote:
> > > On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote:
> > []
> > > > Ok, I agree on the ifdef stuff. My question was regarding your
> > > > suggestion above to replace print_hex_debug() with dev_dbg()
> > > 
> > > You want the device name/id/label to show up as well, that is why you
> > > should use the dev_dbg() version, print_hex_dump() does not take a
> > > struct device *, so the user has no idea what device this data was
> > > coming from.
> > 
> > But Michalis could alway add something like:
> > 	dev_hex_dump()
> > and
> > 	dev_dbg_hex_dump()
> > 
> 
> With the built-in "hex dump primitive" in printk(), why would you want
> to do that?  You shouldn't be putting more than 64 bytes in a single
> printk message in a hex dump, if you want to do more, use debugfs.

%p*h doesn't also emit "ascii or dots" for one.
 
I agree %p*h should be preferred but people do
all sorts of strange things in debugging printks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/