Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755166AbaGQBNY (ORCPT ); Wed, 16 Jul 2014 21:13:24 -0400 Received: from mail-vc0-f179.google.com ([209.85.220.179]:44836 "EHLO mail-vc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752706AbaGQBNU (ORCPT ); Wed, 16 Jul 2014 21:13:20 -0400 MIME-Version: 1.0 In-Reply-To: <36350.1405374230@turing-police.cc.vt.edu> References: <1405361664-5210-1-git-send-email-xerofoify@gmail.com> <36350.1405374230@turing-police.cc.vt.edu> Date: Wed, 16 Jul 2014 21:13:19 -0400 Message-ID: Subject: Re: [PATCH] mach-s3c64xx: Remove all defintions not related to regs-clocks From: Nick Krause To: Valdis.Kletnieks@vt.edu Cc: ben-linux , "kgene.kim" , Russell King - ARM Linux , Tomasz Figa , linux-arm-kernel@lists.infradead.org, linux-samsung-soc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 14, 2014 at 5:43 PM, wrote: > On Mon, 14 Jul 2014 14:14:24 -0400, Nicholas Krause said: >> This patch addresses the fix me message in this file that states to >> remove all definitions not related to reg-clocks in this header >> file. >> >> Signed-off-by: Nicholas Krause >> --- >> arch/arm/mach-s3c64xx/include/mach/regs-clock.h | 22 +--------------------- >> 1 file changed, 1 insertion(+), 21 deletions(-) > >> -#endif /* _PLAT_REGS_CLOCK_H */ >> +/#endif /* _PLAT_REGS_CLOCK_H */ > > You're kidding us, right? Given that this was obviously *not* compile > tested at all, why should we believe that in fact all those #defines > are in fact no longer used? > > Hint: There's a very high chance that somebody stuck that FIXME in there rather > than just cleaning it up themselves precisely *because* it was still in use in > an inconvenient to fix place in the tree.. > I build the arch/arm directory I seem to me hitting a error. arch/arm/xen/enlighten.c:17:29: fatal error: asm/system_misc.h: No such file or directory #include I am also looking into fixing this issue. Cheers Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/