Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754053AbaGQGd7 (ORCPT ); Thu, 17 Jul 2014 02:33:59 -0400 Received: from mail-qa0-f41.google.com ([209.85.216.41]:55854 "EHLO mail-qa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753951AbaGQGdz (ORCPT ); Thu, 17 Jul 2014 02:33:55 -0400 MIME-Version: 1.0 In-Reply-To: References: <1405413956-2772-1-git-send-email-lftan@altera.com> <1405413956-2772-13-git-send-email-lftan@altera.com> Date: Thu, 17 Jul 2014 14:33:54 +0800 X-Google-Sender-Auth: 67fmWvK1nFmR2lUGzdqvGtHPYaQ Message-ID: Subject: Re: [PATCH v2 12/29] nios2: Interrupt handling From: Ley Foon Tan To: Thomas Gleixner Cc: Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , Chung-Lin Tang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 15, 2014 at 5:51 PM, Thomas Gleixner wrote: > On Tue, 15 Jul 2014, Ley Foon Tan wrote: >> +#ifndef _ASM_NIOS2_IRQ_H >> +#define _ASM_NIOS2_IRQ_H >> + >> +#define NIOS2_CPU_NR_IRQS 32 >> +/* Reserve 32 additional interrupts for GPIO IRQs */ >> +#define NR_IRQS (NIOS2_CPU_NR_IRQS + 32) > > Please use sparse irqs. Hardcoded limits tend to work out really bad. Yes, will change this. > >> +#include >> +#include >> +#include >> + >> +static void chip_unmask(struct irq_data *d) >> +{ >> + u32 ien; >> + ien = RDCTL(CTL_IENABLE); >> + ien |= (1 << d->hwirq); >> + WRCTL(CTL_IENABLE, ien); > > So this is UP only, right? Yes, this is to enable one interrupt. > > Also why don't you cache the register content so spare the extra read > from the hardware? Need to make sure nobody modify the register if we cache the register content. Will keep as it is. Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/