Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756050AbaGQJSK (ORCPT ); Thu, 17 Jul 2014 05:18:10 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:44735 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755180AbaGQJSH (ORCPT ); Thu, 17 Jul 2014 05:18:07 -0400 Date: Thu, 17 Jul 2014 12:16:02 +0300 From: Dan Carpenter To: Chen Gang Cc: Thierry Reding , linux-iio@vger.kernel.org, Benjamin Herrenschmidt , teg@jklm.no, Lennox Wu , Marek Vasut , Liqin Chen , Lars-Peter Clausen , Richard Weinberger , Geert Uytterhoeven , msalter@redhat.com, Guenter Roeck , linux-pwm@vger.kernel.org, devel@driverdev.osuosl.org, linux-watchdog@vger.kernel.org, arnd@arndb.de, linux-input@vger.kernel.org, Greg Kroah-Hartman , dmitry.torokhov@gmail.com, "linux-kernel@vger.kernel.org" , knaack.h@gmx.de, Martin Schwidefsky , Mischa.Jonker@synopsys.com, jic23@kernel.org Subject: Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource' Message-ID: <20140717091601.GF25880@mwanda> References: <53C3994C.1010309@metafoo.de> <53C39B66.4060500@nod.at> <5A40E1FC-CA61-4AFF-B205-4BAC175AA7AC@gmail.com> <53C47725.8000005@gmail.com> <53C47B76.4080306@roeck-us.net> <53C47FB7.6080304@gmail.com> <53C53CE1.4090803@gmail.com> <53C7269E.4010702@gmail.com> <20140717083756.GA19686@ulmo> <53C7905D.9090003@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53C7905D.9090003@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: > >> + return (__force void __iomem *)ERR_PTR(-ENXIO); > > > > There's apparently an IOMEM_ERR_PTR() for this nowadays... > > > > IOMEM_ERR_PTR() is defined within "lib/devres.c", not in "./include". > But may we move it from "lib/devres.c" to "./include/linux/err.h"? > > For me, I am not quite sure, it may need additional discussion, but at > least, that will be another patch. Yes. Move it there. That is the right place. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/