Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756737AbaGQKgw (ORCPT ); Thu, 17 Jul 2014 06:36:52 -0400 Received: from smtp81.iad3a.emailsrvr.com ([173.203.187.81]:42015 "EHLO smtp81.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755535AbaGQKgt convert rfc822-to-8bit (ORCPT ); Thu, 17 Jul 2014 06:36:49 -0400 X-Greylist: delayed 383 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Jul 2014 06:36:49 EDT Date: Thu, 17 Jul 2014 06:30:24 -0400 (EDT) Subject: RE: [Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers From: kiran.padwal@smartplayin.com To: "Andy Gross" Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Ivan T. Ivanov" , linux-arm-kernel@lists.infradead.org, "Kumar Gala" , jackp@codeaurora.org, linux-arm-msm@vger.kernel.org, "Andy Gross" MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 Content-Transfer-Encoding: 8BIT Importance: Normal X-Priority: 3 (Normal) X-Type: plain In-Reply-To: References: <1404144233-17222-1-git-send-email-agross@codeaurora.org> <1404144233-17222-3-git-send-email-agross@codeaurora.org> Message-ID: <1405593024.423213197@apps.rackspace.com> X-Mailer: webmail7.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jun 30, 2014 at 9:33 PM, Andy Gross wrote: > From: "Ivan T. Ivanov" > > These drivers handles control and configuration of the HS > and SS USB PHY transceivers. They are part of the driver . [snip] . > +#include > + > +/** > + * USB QSCRATCH Hardware registers > + */ unused define, can you please remove it > +#define QSCRATCH_CTRL_REG (0x04) > +#define QSCRATCH_GENERAL_CFG (0x08) > +#define PHY_CTRL_REG (0x10) > +#define PARAMETER_OVERRIDE_X_REG (0x14) ditto > +#define CHARGING_DET_CTRL_REG (0x18) ditto > +#define CHARGING_DET_OUTPUT_REG (0x1c) ditto > +#define ALT_INTERRUPT_EN_REG (0x20) ditto > +#define PHY_IRQ_STAT_REG (0x24) ditto > +#define CGCTL_REG (0x28) > + > +#define PHY_3P3_VOL_MIN 3050000 /* uV */ > +#define PHY_3P3_VOL_MAX 3300000 /* uV */ > +#define PHY_3P3_HPM_LOAD 16000 /* uA */ > + . [snip] . > +MODULE_ALIAS("platform:qcom-dwc3-ssphy"); > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("DesignWare USB3 QCOM SSPHY driver"); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > Regards, Kiran Padwal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/