Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933006AbaGQNbU (ORCPT ); Thu, 17 Jul 2014 09:31:20 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:56945 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932139AbaGQNbS (ORCPT ); Thu, 17 Jul 2014 09:31:18 -0400 Date: Thu, 17 Jul 2014 14:31:08 +0100 From: Mark Rutland To: Heiko =?utf-8?Q?St=C3=BCbner?= Cc: "suravee.suthikulpanit@amd.com" , "jason@lakedaemon.net" , "linux-arm-kernel@lists.infradead.org" , Marc Zyngier , "devicetree@vger.kernel.org" , Pawel Moll , "linux-doc@vger.kernel.org" , Catalin Marinas , "Harish.Kasiviswanathan@amd.com" , "linux-kernel@vger.kernel.org" , Will Deacon , "linux-pci@vger.kernel.org" , "tglx@linutronix.de" Subject: Re: [PATCH] irqchip: gic: Add binding probe for ARM GIC400 Message-ID: <20140717133108.GL30313@leverpostej> References: <1404947104-21345-1-git-send-email-suravee.suthikulpanit@amd.com> <1404947104-21345-2-git-send-email-suravee.suthikulpanit@amd.com> <2932284.F1eaAf8ArJ@diego> <2621565.f5eISveXXJ@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2621565.f5eISveXXJ@diego> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 14, 2014 at 11:03:03PM +0100, Heiko Stübner wrote: > From: Suravee Suthikulpanit > > Commit 3ab72f9156bb "dt-bindings: add GIC-400 binding" added the > "arm,gic-400" compatible string, but the corresponding IRQCHIP_DECLARE > was never added to the gic driver. > > Therefore add the missing irqchip declaration for it. > > Signed-off-by: Suravee Suthikulpanit > > Removed additional empty line and adapted commit message to mark it > as fixing an issue. > Signed-off-by: Heiko Stuebner > --- > As I really need this, I took the liberty of adapting the patch accordingly > to make it apply on top of the current irqchip/for-next (or urgent) and > explicitly state the fixed issue. Hope that is ok While this is a fix that we should have, I'm not certain I see why this is urgent. A dt can already have: compatible = "arm,gic-400", "arm,cortex-a15-gic"; Which will work _today_, before this patch. If we need to treat the A15 GIC string differently, we'll have to ensure we support the GIC 400 string first. Thanks, Mark. > > drivers/irqchip/irq-gic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c > index 9d26643..6ff28b4 100644 > --- a/drivers/irqchip/irq-gic.c > +++ b/drivers/irqchip/irq-gic.c > @@ -1020,6 +1020,7 @@ gic_of_init(struct device_node *node, struct device_node *parent) > gic_cnt++; > return 0; > } > +IRQCHIP_DECLARE(gic_400, "arm,gic-400", gic_of_init); > IRQCHIP_DECLARE(cortex_a15_gic, "arm,cortex-a15-gic", gic_of_init); > IRQCHIP_DECLARE(cortex_a9_gic, "arm,cortex-a9-gic", gic_of_init); > IRQCHIP_DECLARE(cortex_a7_gic, "arm,cortex-a7-gic", gic_of_init); > -- > 1.9.0 > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/