Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933918AbaGQPAG (ORCPT ); Thu, 17 Jul 2014 11:00:06 -0400 Received: from mail-we0-f175.google.com ([74.125.82.175]:55331 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932908AbaGQPAE (ORCPT ); Thu, 17 Jul 2014 11:00:04 -0400 Date: Thu, 17 Jul 2014 16:59:59 +0200 From: Thierry Reding To: Bastian Hecht Cc: linux-i2c@vger.kernel.org, Linux-SH , Tomoya MORINAGA , Wolfram Sang , linux-arm-kernel@lists.infradead.org, Laxman Dewangan , Stephen Warren , "open list:TEGRA ARCHITECTUR..." , open list Subject: Re: [PATCH v2 5/5] i2c: tegra: Remove suspension check Message-ID: <20140717145958.GA32534@ulmo> References: <1405608520-5644-1-git-send-email-hechtb@gmail.com> <1405608520-5644-5-git-send-email-hechtb@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE" Content-Disposition: inline In-Reply-To: <1405608520-5644-5-git-send-email-hechtb@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Kj7319i9nmIyA2yE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 17, 2014 at 04:48:40PM +0200, Bastian Hecht wrote: [...] > #ifdef CONFIG_PM_SLEEP > -static int tegra_i2c_suspend(struct device *dev) > -{ > - struct tegra_i2c_dev *i2c_dev =3D dev_get_drvdata(dev); > - > - i2c_lock_adapter(&i2c_dev->adapter); > - i2c_dev->is_suspended =3D true; > - i2c_unlock_adapter(&i2c_dev->adapter); > - > - return 0; > -} > - > static int tegra_i2c_resume(struct device *dev) > { > struct tegra_i2c_dev *i2c_dev =3D dev_get_drvdata(dev); > @@ -842,14 +827,12 @@ static int tegra_i2c_resume(struct device *dev) > return ret; > } > =20 > - i2c_dev->is_suspended =3D false; > - > i2c_unlock_adapter(&i2c_dev->adapter); > =20 > return 0; > } > =20 > -static SIMPLE_DEV_PM_OPS(tegra_i2c_pm, tegra_i2c_suspend, tegra_i2c_resu= me); > +static SIMPLE_DEV_PM_OPS(tegra_i2c_pm, tegra_i2c_resume); Shouldn't this be: static SIMPLE_DEV_OPS(tegra_i2c_pm, NULL, tegra_i2c_resume); instead? Thierry --Kj7319i9nmIyA2yE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTx+TuAAoJEN0jrNd/PrOhaWwP/AgRxS2d+EecHKjm411ljsiD JwHW+gL42M9tkTIZPTPA1KgiQr+DSAXTBh6Zke621iUDkbMzFsUv4wYYP8tZLXC4 iEL2GaVX1bry8PhwFBe89660oSgnqjpugeM1X7hvXly+Hl89p79JqOkQvdBqa7RO yYPQufIyPhkJzUCu1swiGhoMJGcDjsQAu1ujzSnYhDZNRNf+Bj2Z5mKar4aQy0B6 Y444hBKUZ6zRrnpD/URLBI2963CArwEVBvmO+Pk5xAcWqFYVKjAL1Ot0gUI0tPm1 5RpkZ0mwAMajGbVZAIm8xN5CjP3Ed/MPvACH77dU/PHPxULF7A5Clq3Ev2A3AOnK yvy9fpkiSgaXBXVppxjfmMYNz1NzwdbHmTLNq9RWe9aEslHDod2/inBbsUA3kDMY 9eTVogq27RGgZL9jmtj0FqKp81UQ7up4kRMVmco9XC5245jivBhwhRdgbDGT9LNl SwVh4W/zowGhz432X5uP5llujBgXVFuis9NUcYFYPy6Uw6LXAydEEQKGtlD2UamU sOw6J8+9bSfdwoJLoh+GaH9CGuVIGd7PUMSlxauke+hHHSwBU5BISVNr877XZouD 5f8Qeb2+LRBcxSZigI7FSOZDfZoXIdUURHaPSDDTQEystMCqEE4/4aRNttaH/Mj3 aVAn/fZc2RN2hYaJt/pr =Vn9M -----END PGP SIGNATURE----- --Kj7319i9nmIyA2yE-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/