Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934155AbaGQPcw (ORCPT ); Thu, 17 Jul 2014 11:32:52 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:61014 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933006AbaGQPcu (ORCPT ); Thu, 17 Jul 2014 11:32:50 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 96.249.243.124 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+lEKT41YPn+PJvc+PPVcHtQhahN9gDHHM= X-DKIM: OpenDKIM Filter v2.0.1 titan 153FF5AE5C3 Date: Thu, 17 Jul 2014 11:32:36 -0400 From: Jason Cooper To: Tomasz Figa Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kukjin Kim , Thomas Gleixner , Tomasz Figa , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Lorenzo Pieralisi Subject: Re: [PATCH] irqchip: gic: Fix core ID calculation when topology is read from DT Message-ID: <20140717153236.GS13108@titan.lakedaemon.net> References: <1405610624-18722-1-git-send-email-t.figa@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405610624-18722-1-git-send-email-t.figa@samsung.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 17, 2014 at 05:23:44PM +0200, Tomasz Figa wrote: > Certain GIC implementation, namely those found on earlier, single > cluster, Exynos SoCs, have registers mapped without per-CPU banking, > which means that the driver needs to use different offset for each CPU. > > Currently the driver calculates the offset by multiplying value returned > by cpu_logical_map() by CPU offset parsed from DT. This is correct when > CPU topology is not specified in DT and aforementioned function returns > core ID alone. However when DT contains CPU topology, the function > changes to return cluster ID as well, which is non-zero on mentioned > SoCs and so breaks the calculation in GIC driver. > > This patch fixes this by masking out cluster ID in CPU offset > calculation so that only core ID is considered. Multi-cluster Exynos > SoCs already have banked GIC implementations, so this simple fix should > be enough. > > Reported-by: Lorenzo Pieralisi > Reported-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Tomasz Figa > --- > drivers/irqchip/irq-gic.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) iiuc, this was introduced by: db0d4db22a78d ARM: gic: allow GIC to support non-banked setups and so should be for v3.3 and up, correct? thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/