Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757592AbaGQQjg (ORCPT ); Thu, 17 Jul 2014 12:39:36 -0400 Received: from terminus.zytor.com ([198.137.202.10]:56040 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756898AbaGQQjf (ORCPT ); Thu, 17 Jul 2014 12:39:35 -0400 Message-ID: <53C7FC32.7030704@zytor.com> Date: Thu, 17 Jul 2014 09:39:14 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: "Theodore Ts'o" , Andy Lutomirski , Raghavendra K T , Paolo Bonzini , X86 ML , Bandan Das , Gleb Natapov , kvm list , Srivatsa Vaddagiri , Daniel Borkmann , "linux-kernel@vger.kernel.org" , Kees Cook Subject: Re: [PATCH v3 2/5] random,x86: Add arch_get_slow_rng_u64 References: <5778e65d5ca52bebbaa023e177d863e44f098e96.1405546879.git.luto@amacapital.net> <53C6F5A9.80400@zytor.com> <53C703ED.2010605@zytor.com> <53C75733.8060507@zytor.com> <20140717103324.GJ1491@thunk.org> In-Reply-To: <20140717103324.GJ1491@thunk.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/17/2014 03:33 AM, Theodore Ts'o wrote: > On Wed, Jul 16, 2014 at 09:55:15PM -0700, H. Peter Anvin wrote: >> On 07/16/2014 05:03 PM, Andy Lutomirski wrote: >>>> >>> I meant that prandom isn't using rdrand for early seeding. >>> >> >> We should probably fix that. > > It wouldn't hurt to explicitly use arch_get_random_long() in prandom, > but it does use get_random_bytes() in early seed, and for CPU's with > RDRAND present, we do use it in init_std_data() in > drivers/char/random.c, so prandom is already getting initialized via > an RNG (which is effectively a DRBG even if it doesn't pass all of > NIST's rules) which is derived from RDRAND. > I assumed he was referring to before alternatives. Not sure if we use prandom before that point, though. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/