Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757135AbaGQUlV (ORCPT ); Thu, 17 Jul 2014 16:41:21 -0400 Received: from usmamail.tilera.com ([12.216.194.151]:55097 "EHLO USMAMAIL.TILERA.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751582AbaGQUlT (ORCPT ); Thu, 17 Jul 2014 16:41:19 -0400 X-CheckPoint: {53C834EA-8-2100090A-C0000000} Message-ID: <53C834EA.5030605@tilera.com> Date: Thu, 17 Jul 2014 16:41:14 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Chen Gang , Arnd Bergmann , Lars-Peter Clausen CC: Guenter Roeck , Richard Weinberger , Greg Kroah-Hartman , , , Benjamin Herrenschmidt , , Thierry Reding , Lennox Wu , Marek Vasut , Liqin Chen , , , , , , "linux-kernel@vger.kernel.org" , , Martin Schwidefsky , , , Geert Uytterhoeven Subject: Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource' References: <201407130545.23004.marex@denx.de> <6823014.2plXDE9VA9@wuerfel> <53C7A819.40403@metafoo.de> <6485666.LVFO2YCEQx@wuerfel> <53C7B365.4080000@gmail.com> In-Reply-To: <53C7B365.4080000@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.9.0.23] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/17/2014 7:28 AM, Chen Gang wrote: > On 07/17/2014 06:48 PM, Arnd Bergmann wrote: >> AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take >> a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff >> to build on UML seems pointless to me and we special-case it in a number of >> places already. >> > According to current source code, tile still has chance to choose > NO_IOMEM, for me, welcome the tile's maintainer's ideas or suggestions. I'm not really sure. It's true that on tile, if you don't enable PCI support there's no other I/O memory (or I/O port) space you can use. We pretty much always enable PCI support in our kernel, though. I'm kind of surprised that other architectures don't also have the model that IOMEM requires PCI, but perhaps most architectures just don't encode that in the Kconfig file? My observation is just that if I remove the "NO_IOMEM if !PCI" from arch/tile/Kconfig, my build fails with ioremap() undefined. No doubt I could work around that, but my assumption was that NO_IOMEM was exactly the right thing to express the fact that without PCI there is no I/O memory :-) -- Chris Metcalf, Tilera Corp. http://www.tilera.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/