Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758075AbaGQVkK (ORCPT ); Thu, 17 Jul 2014 17:40:10 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:46664 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752816AbaGQVkI (ORCPT ); Thu, 17 Jul 2014 17:40:08 -0400 MIME-Version: 1.0 In-Reply-To: <53C48986.5010109@oracle.com> References: <1405017631-27346-1-git-send-email-keescook@chromium.org> <20140711164931.GA18473@redhat.com> <53C48986.5010109@oracle.com> From: Andy Lutomirski Date: Thu, 17 Jul 2014 14:39:46 -0700 Message-ID: Subject: Re: [PATCH v10 0/11] seccomp: add thread sync ability To: James Morris Cc: Kees Cook , Oleg Nesterov , LKML , Alexei Starovoitov , "Michael Kerrisk (man-pages)" , Andrew Morton , Daniel Borkmann , Will Drewry , Julien Tinnes , David Drysdale , Linux API , "x86@kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux MIPS Mailing List , linux-arch , linux-security-module Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 14, 2014 at 6:53 PM, James Morris wrote: > On 07/15/2014 04:59 AM, Kees Cook wrote: >> >> Hi James, >> >> Is this series something you would carry in the security-next tree? >> That has traditionally been where seccomp features have landed in the >> past. >> >> -Kees >> >> >> On Fri, Jul 11, 2014 at 10:55 AM, Kees Cook wrote: >>> >>> On Fri, Jul 11, 2014 at 9:49 AM, Oleg Nesterov wrote: >>>> >>>> On 07/10, Kees Cook wrote: >>>>> >>>>> >>>>> This adds the ability for threads to request seccomp filter >>>>> synchronization across their thread group (at filter attach time). >>>>> For example, for Chrome to make sure graphic driver threads are fully >>>>> confined after seccomp filters have been attached. >>>>> >>>>> To support this, locking on seccomp changes via thread-group-shared >>>>> sighand lock is introduced, along with refactoring of no_new_privs. >>>>> Races >>>>> with thread creation are handled via delayed duplication of the seccomp >>>>> task struct field and cred_guard_mutex. >>>>> >>>>> This includes a new syscall (instead of adding a new prctl option), >>>>> as suggested by Andy Lutomirski and Michael Kerrisk. >>>> >>>> >>>> I do not not see any problems in this version, >>> >>> >>> Awesome! Thank you for all the reviews. :) If Andy and Michael are >>> happy with this too, I think this is in good shape. \o/ >>> >>> -Kees >>> >>>> >>>> Reviewed-by: Oleg Nesterov >>>> >>> >>> >>> >>> -- >>> Kees Cook >>> Chrome OS Security >> >> >> >> > > Yep, certainly. > Any ETA? I'm currently blocking on having stable commit hashes for these. If you're planning on pulling from Kees' tree instead of importing the patches, I can work with that, too. Thanks, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/