Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753577AbaGRHZo (ORCPT ); Fri, 18 Jul 2014 03:25:44 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:35335 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbaGRHZm (ORCPT ); Fri, 18 Jul 2014 03:25:42 -0400 Date: Fri, 18 Jul 2014 08:25:36 +0100 From: Lee Jones To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, wim@iguana.be, linux-watchdog@vger.kernel.org Subject: Re: [PATCH v3 1/3] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-ID: <20140718072536.GI30888@lee--X1> References: <20140717124156.GF30888@lee--X1> <20140717140653.GA8468@awelinux> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140717140653.GA8468@awelinux> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Jul 2014, Andreas Werner wrote: > On Thu, Jul 17, 2014 at 01:41:56PM +0100, Lee Jones wrote: > > On Thu, 17 Jul 2014, Andreas Werner wrote: > > > The MEN 14F021P00 Board Management Controller provides an > > > I2C interface to the host to access the feature implemented in the BMC. > > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikroelektronik > > > and on a few Box/Display Computer. > > > > > > Added MFD Core driver, supporting the I2C communication to the device. > > > > > > The MFD driver currently supports the following features: > > > - Watchdog > > > - LEDs > > > > > > Signed-off-by: Andreas Werner > > > --- > > > drivers/mfd/Kconfig | 12 +++++ > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/menf21bmc.c | 136 ++++++++++++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 149 insertions(+) > > > create mode 100644 drivers/mfd/menf21bmc.c > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index b8d9ca0..6e2cd14 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > > additional drivers must be enabled in order to use the functionality > > > of the device. > > > > > > +config MFD_MENF21BMC > > > + tristate "MEN 14F021P00 Board Management Controller Support" > > > + depends on I2C=y > > > + select MFD_CORE > > > + help > > > + Say yes here to add support for the MEN 14F021P00 BMC > > > + which is a Board Management Controller connected to the I2C bus. > > > + The device supports multiple sub-devices like LED and WDT. > > > + This driver provides common support for accessing the devices; > > > + additional drivers must be enabled in order to use the > > > + functionality of the BMC device. > > > > Can you mention what those devices are here in the help text? > > > > I've mentioned the sub-devices "LED" and "WDT" but i can also write > the name to the help text like "menf21bmc_wdt" and "leds-menf21bmc". Scrap this comment, I was being silly and didn't see "LED and WDT". [...] > > > +MODULE_DEVICE_TABLE(i2c, menf21bmc_id_table); > > > + > > > +static struct i2c_driver menf21bmc_driver = { > > > + .driver = { > > > + .name = "menf21bmc", > > > + .owner = THIS_MODULE, > > > > Remove this line, it's handled elsewhere. > > Which line? the ".owner" line? Yeah. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/