Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760914AbaGRI71 (ORCPT ); Fri, 18 Jul 2014 04:59:27 -0400 Received: from mail-yh0-f47.google.com ([209.85.213.47]:57770 "EHLO mail-yh0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755180AbaGRI7Y (ORCPT ); Fri, 18 Jul 2014 04:59:24 -0400 MIME-Version: 1.0 X-Originating-IP: [84.208.72.173] In-Reply-To: <20140717.162040.171795478640839195.davem@davemloft.net> References: <1405584370-30054-1-git-send-email-teg@jklm.no> <1405584370-30054-5-git-send-email-teg@jklm.no> <20140717.162040.171795478640839195.davem@davemloft.net> From: Tom Gundersen Date: Fri, 18 Jul 2014 10:59:04 +0200 Message-ID: Subject: Re: [PATCH net-next v9 4/9] net: set name_assign_type when setting names via ioctls To: David Miller Cc: netdev , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 18, 2014 at 1:20 AM, David Miller wrote: > From: Tom Gundersen > Date: Thu, 17 Jul 2014 10:06:05 +0200 > >> @@ -2787,10 +2788,13 @@ static int gsm_create_network(struct gsm_dlci *dlci, struct gsm_netconfig *nc) >> pr_debug("create network interface"); >> >> netname = "gsm%d"; >> - if (nc->if_name[0] != '\0') >> + if (nc->if_name[0] != '\0') { >> netname = nc->if_name; >> - net = alloc_netdev(sizeof(struct gsm_mux_net), netname, >> - NET_NAME_UNKNOWN, gsm_mux_net_init); >> + name_assign_type = NET_NAME_USER; >> + } >> + net = alloc_netdev(sizeof(struct gsm_mux_net), >> + netname, name_assign_type, >> + gsm_mux_net_init); > > The indentation is now not correct. For a function call, all arguments on the > second and subsequent line, must start exactly at the first column after the > openning parenthesis of the function call. Indeed. Thanks, I'll fix this up. Cheers, Tom -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/