Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933817AbaGRJ22 (ORCPT ); Fri, 18 Jul 2014 05:28:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52812 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933281AbaGRJ20 (ORCPT ); Fri, 18 Jul 2014 05:28:26 -0400 Date: Fri, 18 Jul 2014 14:57:37 +0530 From: Amit Shah To: Herbert Xu Cc: Jason Cooper , linux-kernel@vger.kernel.org, Virtualization List , Rusty Russell , keescook@chromium.org Subject: Re: [RFC PATCH 1/3] hw_random: allow RNG devices to give early randomness after a delay Message-ID: <20140718092737.GD15020@grmbl.mre> References: <685be569a29015d3ee56cc3f782d81cae06d52b9.1405277045.git.amit.shah@redhat.com> <20140714123700.GP13108@titan.lakedaemon.net> <20140714124246.GA1520@grmbl.mre> <20140718085626.GA15020@grmbl.mre> <20140718091408.GA17266@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140718091408.GA17266@gondor.apana.org.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (Fri) 18 Jul 2014 [17:14:08], Herbert Xu wrote: > On Fri, Jul 18, 2014 at 02:26:26PM +0530, Amit Shah wrote: > > > > > Sounds like a good idea to me. Though, changes in core.c that > > > increase the time in hwrng_register() or hwrng_init() may not get > > > noticed by rng drivers and they may suddenly start failing for no > > > apparent reason. Seems like a far stretch, though. Does anyone else > > > have an opinion on this? > > > > Herbert, do you have any preference? > > So it's only virtio-rng that's a problem, right? How about if we > abuse the scan hook in virtio and move the hwrng_register there? Oops, I had completely missed the scan hook, and looks like it was added for exactly the purpose we want here (so we won't even be abusing it!) Thanks! I'll post the patches when the one to revert gets an upstream commit id. Amit -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/