From: Arnd Bergmann <arnd@arndb.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ley Foon Tan <lftan@altera.com>, Linux-Arch <linux-arch@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        Chung-Lin Tang <cltang@codesourcery.com>
Subject: Re: [PATCH v2 21/29] nios2: Futex operations
Date: Fri, 18 Jul 2014 11:55:26 +0200
Message-ID: <5659104.6O7AZx76W6@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <alpine.DEB.2.10.1407181140250.24854@nanos>
References: <1405413956-2772-1-git-send-email-lftan@altera.com> <17186253.ZJUn1qWK0f@wuerfel> <alpine.DEB.2.10.1407181140250.24854@nanos>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org

On Friday 18 July 2014 11:42:34 Thomas Gleixner wrote:
> On Fri, 18 Jul 2014, Arnd Bergmann wrote:
> > On Friday 18 July 2014 14:07:42 Ley Foon Tan wrote:
> > > On Thu, Jul 17, 2014 at 7:07 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > If this understanding is right, we can probably just merge the
> > m68k implementation into the asm-generic version, as that does
> > exactly that, and just isn't SMP safe. I'm still unsure whether
> > I'm missing something here though, as everything else seems to
> > do this in assembly, even for non-SMP machines that could use
> > the trivial method that m68k has.
> 
> For UP relying of pagefault disable should be good enough indeed. I
> guess the asm for the other UP stuff results from looking at
> architectures or copying from architectures which did this in ASM 

Ok, thanks for the confirmation!

Ley Foon Tan, I think the best way forward then is for you to
take the m68k code and copy (or move) that into asm-generic/futex.h
under an #ifndef CONFIG_SMP.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/