Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761023AbaGROCS (ORCPT ); Fri, 18 Jul 2014 10:02:18 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:57859 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756335AbaGROCR (ORCPT ); Fri, 18 Jul 2014 10:02:17 -0400 Message-ID: <53C928EA.4000800@linaro.org> Date: Fri, 18 Jul 2014 09:02:18 -0500 From: Alex Elder User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Petr_Ml=E1dek?= CC: akpm@linux-foundation.org, bp@suse.de, john.stultz@linaro.org, jack@suse.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/6] printk: insert newline in devkmsg_read() References: <1405606151-19875-1-git-send-email-elder@linaro.org> <1405606151-19875-6-git-send-email-elder@linaro.org> <20140718114506.GA6774@pathway.suse.cz> In-Reply-To: <20140718114506.GA6774@pathway.suse.cz> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/18/2014 06:45 AM, Petr Ml?dek wrote: > On Thu 2014-07-17 09:09:10, Alex Elder wrote: >> If a log record has LOG_PREFIX set, its predecessor record should be >> terminated if it was marked LOG_CONT. In devkmsg_read(), this >> condition was being ignored, which would lead to such records >> showing up combined when reading /dev/kmsg. Fix this oversight. >> >> Reported-by: Petr Ml?dek >> Signed-off-by: Alex Elder >> --- >> kernel/printk/printk.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c >> index e5ee1cb..3174ba9 100644 >> --- a/kernel/printk/printk.c >> +++ b/kernel/printk/printk.c >> @@ -575,6 +575,7 @@ static ssize_t devkmsg_read(struct file *file, char __user *buf, >> char cont; >> size_t len; >> ssize_t ret; >> + bool insert_newline; >> >> if (!user) >> return -EBADF; >> @@ -626,7 +627,10 @@ static ssize_t devkmsg_read(struct file *file, char __user *buf, >> else >> cont = '-'; >> >> - len = sprintf(user->buf, "%u,%llu,%llu,%c;", >> + /* Insert a newline if we're terminating the previous record >> early */ > > More correct description would be: > > /* Insert a newline if the previous line was not terminated properly */ I will change it as you suggest. > >> + insert_newline = (user->prev & LOG_CONT) && (msg->flags & LOG_PREFIX); >> + len = sprintf(user->buf, "%s%u,%llu,%llu,%c;", >> + insert_newline ? "\n" : "", >> (msg->facility << 3) | msg->level, >> user->seq, ts_usec, cont); >> user->prev = msg->flags; > > Please, do similar change also in msg_print_text() that would fix also > syslog(). Note that syslog is the place where we stopped to disable > prefix when there was continuous line before. I will do this, as you will see in v3 which I plan to post in a few hours. (Note that this touches a spot where I have yet another minor bug fix that I have not yet posted... Oh well.) -Alex > Best Regards. > Petr > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/