Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762161AbaGROVm (ORCPT ); Fri, 18 Jul 2014 10:21:42 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:37046 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762075AbaGROVj (ORCPT ); Fri, 18 Jul 2014 10:21:39 -0400 Message-ID: <53C92D70.6050604@atmel.com> Date: Fri, 18 Jul 2014 16:21:36 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Florian Fainelli CC: Boris BREZILLON , "Jean-Christophe Plagniol-Villard" , Alexandre Belloni , Andrew Victor , , , "Rob Herring" , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , , "David S. Miller" , Subject: Re: [PATCH v3 1/2] ARM: at91/dt: describe rgmii ethernet phy connected to sama5d3xek boards References: <1405022394-8311-1-git-send-email-boris.brezillon@free-electrons.com> <1405022394-8311-2-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: <1405022394-8311-2-git-send-email-boris.brezillon@free-electrons.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/2014 21:59, Boris BREZILLON : > Add ethernet-phy nodes and specify phy interrupt (connected to pin PB25) > and board specific timing configs. > > Atmel has two different HW designs for its CPU modules: the first one > (produced by Embest) is connecting PHYAD[0-2] pins to pull up resistors > and the other one (produced by Ronetix) is connecting PHYAD0 to a pull up > resistor and PHYAD[1-2] to pull down resistors. > As a result, Ronetix design will have its PHY available at address 0x1 and > Embest design at 0x7. > By defining both phys we're letting the phy core detect the one actually > available on the MDIO bus. > > Signed-off-by: Boris BREZILLON > --- > > Florian, I dropped your Reviewed-by tag because this patch has slightly > changed. Hi Florian, I would like to have your Ack on this one as we discussed this solution with you. Thanks, bye, > arch/arm/boot/dts/sama5d3xcm.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm/boot/dts/sama5d3xcm.dtsi b/arch/arm/boot/dts/sama5d3xcm.dtsi > index b0b1331..755369e 100644 > --- a/arch/arm/boot/dts/sama5d3xcm.dtsi > +++ b/arch/arm/boot/dts/sama5d3xcm.dtsi > @@ -34,6 +34,36 @@ > > macb0: ethernet@f0028000 { > phy-mode = "rgmii"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet-phy@1 { > + reg = <0x1>; > + interrupt-parent = <&pioB>; > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > + txen-skew-ps = <800>; > + txc-skew-ps = <3000>; > + rxdv-skew-ps = <400>; > + rxc-skew-ps = <3000>; > + rxd0-skew-ps = <400>; > + rxd1-skew-ps = <400>; > + rxd2-skew-ps = <400>; > + rxd3-skew-ps = <400>; > + }; > + > + ethernet-phy@7 { > + reg = <0x7>; > + interrupt-parent = <&pioB>; > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > + txen-skew-ps = <800>; > + txc-skew-ps = <3000>; > + rxdv-skew-ps = <400>; > + rxc-skew-ps = <3000>; > + rxd0-skew-ps = <400>; > + rxd1-skew-ps = <400>; > + rxd2-skew-ps = <400>; > + rxd3-skew-ps = <400>; > + }; > }; > > pmc: pmc@fffffc00 { > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/