Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762605AbaGROp3 (ORCPT ); Fri, 18 Jul 2014 10:45:29 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:54811 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1761477AbaGROp1 (ORCPT ); Fri, 18 Jul 2014 10:45:27 -0400 Date: Fri, 18 Jul 2014 10:45:26 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Nick Krause cc: Greg KH , , , , , , , , , "linux-kernel@vger.kernel.org" Subject: Re: hcd.c Fix me statements In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Jul 2014, Nick Krause wrote: > I am assuming this is a stupid question but since I am new I will ask it anyway. > Can the usb_bus structure be Null? If can I will send it a patch removing the > fix mes on lines 854 and 878 of hcd.c . Line numbers in a source file usually aren't very useful. They're different in every version of the kernel. Instead just mention which functions you're talking about. It looks like authorized_default_show() and authorized_default_store(). Yes, it's true that usb_bus (which is a pointer, not a structure) can never be NULL. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/