Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935111AbaGRQbx (ORCPT ); Fri, 18 Jul 2014 12:31:53 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:52948 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932078AbaGRQbv (ORCPT ); Fri, 18 Jul 2014 12:31:51 -0400 From: Arnd Bergmann To: Chanwoo Choi Cc: linux-arm-kernel , Mark Rutland , devicetree , Kukjin Kim , pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-iio@vger.kernel.org, Tomasz Figa , rdunlap@infradead.org, linux-doc@vger.kernel.org, linux-kernel , Rob Herring , Chanwoo Choi , Kyungmin Park , linux-samsung-soc , galak@codeaurora.org, naveen krishna , jic23@kernel.org Subject: Re: [PATCHv6 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC Date: Fri, 18 Jul 2014 18:31:40 +0200 Message-ID: <10264770.8SXiIS8qhq@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1405663186-26464-1-git-send-email-cw00.choi@samsung.com> <32226622.5gSmvBRKvZ@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V02:K0:dl75VlJUepIMnpfzA5SFy87pVStdHBrN4T8H8mQM1OK wAJrvnTjIBEw6bQatU+Ggs4LFj10rbJVeBbGMNUtPytcpPoHUD 0KEblw6YDBQdFHmZuGveyVvp5Kj9W0QzX+yKa93eRAEZRUk6zL vZKqAMVhSJIkZFxxHI9vz69LA/n5Oe9jvvdAdeU3EwtOVSUV/8 /ywwGoJi/C/PxvQNA/YRNOgkfRg0ojoBiMQqEfrG7ZfCcS1/Ej G++6bro9AKGpljpDYkXpRePGy0kqsMf1aSEMExW22+UqExmXWy E+Ev5RA9lsm9gqbggbEvxYt4/aiJSPI3HrnZPmpc3PXu40V+Wu OnRvfqpu7fYOqxiifHi0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 19 July 2014 01:11:53 Chanwoo Choi wrote: > > Exynos3250/Exynos4/Exynos5 has 'adc' clock as following: > - 'adc' clock: bus clock for ADC > > Exynos3250 has additional 'sclk_adc' clock as following: > - 'sclk_adc' clock: special clock for ADC which provide clock to internal ADC The bus clock is often named "apb_pclk", but it's too late to change that now, and it's not clear if the device is actually on APB. The problem with "sclk_adc" is that it's very close to the name used in the clock provider, with is CLK_SCLK_TSADC. Please try to avoid the ambiguity here and make it clear that they are not referring to the same thing. "internal" or "special" might be good if you want to avoid "sclk". Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/