Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030414AbaGRQdu (ORCPT ); Fri, 18 Jul 2014 12:33:50 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:58082 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935023AbaGRQdq (ORCPT ); Fri, 18 Jul 2014 12:33:46 -0400 From: Arnd Bergmann To: Chanwoo Choi Cc: Chanwoo Choi , jic23@kernel.org, naveen krishna , Kukjin Kim , Rob Herring , pawel.moll@arm.com, Mark Rutland , ijc+devicetree@hellion.org.uk, Kumar Gala , rdunlap@infradead.org, Kyungmin Park , Tomasz Figa , linux-iio@vger.kernel.org, linux-samsung-soc , linux-kernel , linux-arm-kernel , devicetree , linux-doc@vger.kernel.org Subject: Re: [PATCHv6 3/4] iio: devicetree: Add DT binding documentation for Exynos3250 ADC Date: Fri, 18 Jul 2014 18:33:06 +0200 Message-ID: <5835825.JtcDoyOP8b@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1405663186-26464-1-git-send-email-cw00.choi@samsung.com> <6104032.PNRl85V92G@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V02:K0:bdEDxTKT93HqH+nFhUm0bYFUcOTrOgVHi+XF3JnBqGc u7dc4xG8Yz3IKXdZ4M2TZECqh7pLUJNAIG5stuklkjvryCggXH ly0uLjBcp2IPWO01yqWEwlpGmrTNL/v5a4nnDESRahsS58vtQH XlIlfcCG4K9Po18ZTHLV6cPDe72eCCiGRCkXCOIJ/r+PYki09A mBJTTPgWp38Khe0Z0+va8lXDyz3uc+Kxk6lMqGidx4IqIyVZ75 KNzg68bo2HNjjxRej1Y3R6S/k2vSAAieLRo9a1dMx4iGVU7epE zMLrIo7ylQh1zFNbEvnVxMwyq5AhDt5TWYmhDyWzuiLCCZ7jfg DZqoDCb1cQJLRa9Dix8I= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 19 July 2014 01:23:15 Chanwoo Choi wrote: > If don't add new compatible including specific exynos version, > I would add new 'adc-needs-sclk' property with existing 'exynos-adc-v2' > compatible name. > > > Dear Naveen, Tomasz, > > If existing exynos-adc driver add just one property for 'sclk_adc' > as following, exynos-adc could not include the exynos version > in compatible name. > > I need your opinion about it. > > adc: adc@126C0000 { > compatible = "samsung,exynos-adc-v2"; > reg = <0x126C0000 0x100>, <0x10020718 0x4>; > interrupts = <0 137 0>; > clock-names = "adc", "sclk_adc"; > clocks = <&cmu CLK_TSADC>, <&cmu CLK_SCLK_TSADC>; > + adc-needs-sclk; > #io-channel-cells = <1>; > io-channel-ranges; > } How about just making it an optional clock? That would be much easier because then you can simply see if the clock itself is there and use it, or otherwise ignore it. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/