Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030597AbaGRQoe (ORCPT ); Fri, 18 Jul 2014 12:44:34 -0400 Received: from mail-bl2lp0212.outbound.protection.outlook.com ([207.46.163.212]:14759 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030534AbaGRQob convert rfc822-to-8bit (ORCPT ); Fri, 18 Jul 2014 12:44:31 -0400 From: KY Srinivasan To: "Christoph Hellwig (hch@infradead.org)" CC: Jens Axboe , James Bottomley , "michaelc@cs.wisc.edu" , "linux-scsi@vger.kernel.org" , "gregkh@linuxfoundation.org" , "jasowang@redhat.com" , "linux-kernel@vger.kernel.org" , "ohering@suse.com" , "apw@canonical.com" , "devel@linuxdriverproject.org" Subject: RE: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout Thread-Topic: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout Thread-Index: AQHPgAqq5L1zp+ngQ0O2dQQp+rFvKZthLVSAgAABPoCAAh+9gIAAFcfQgADyoICAAAl2AIAACGQAgBY2XeCAKpUUYIABAMeAgAAYEBA= Date: Fri, 18 Jul 2014 16:44:14 +0000 Message-ID: <2d43adebbc47441084d8e1284507a427@BY2PR0301MB0711.namprd03.prod.outlook.com> References: <1401899623-24194-1-git-send-email-kys@microsoft.com> <1401901323.17510.23.camel@dabdike> <53911A35.7010805@cs.wisc.edu> <5391F801.4010107@cs.wisc.edu> <1402077167.2207.89.camel@dabdike.int.hansenpartnership.com> <539206FA.1020001@kernel.dk> <5b926a0a9f264edda91c7c2ab0acb7d1@BY2PR03MB299.namprd03.prod.outlook.com> <13807d2cc8744ae1bc374f20d8f9caec@BY2PR0301MB0711.namprd03.prod.outlook.com> <20140718151039.GA7425@infradead.org> In-Reply-To: <20140718151039.GA7425@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [50.135.110.52] x-microsoft-antispam: BCL:0;PCL:0;RULEID: x-forefront-prvs: 02760F0D1C x-forefront-antispam-report: SFV:NSPM;SFS:(6009001)(24454002)(51704005)(13464003)(199002)(189002)(377454003)(93886003)(19580395003)(76176999)(54356999)(19580405001)(15975445006)(66066001)(86362001)(107046002)(20776003)(101416001)(85852003)(76576001)(83072002)(110136001)(21056001)(92566001)(83322001)(86612001)(105586002)(2656002)(87936001)(15202345003)(99286002)(106356001)(77096002)(95666004)(106116001)(64706001)(74316001)(46102001)(50986999)(99396002)(85306003)(77982001)(4396001)(80022001)(33646002)(76482001)(31966008)(81342001)(81542001)(79102001)(74502001)(74662001)(108616002)(24736002);DIR:OUT;SFP:;SCL:1;SRVR:BY2PR0301MB0712;H:BY2PR0301MB0711.namprd03.prod.outlook.com;FPR:;MLV:sfv;PTR:InfoNoRecords;MX:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID: X-OriginatorOrg: microsoft.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Christoph Hellwig (hch@infradead.org) [mailto:hch@infradead.org] > Sent: Friday, July 18, 2014 8:11 AM > To: KY Srinivasan > Cc: Jens Axboe; James Bottomley; michaelc@cs.wisc.edu; Christoph Hellwig > (hch@infradead.org); linux-scsi@vger.kernel.org; > gregkh@linuxfoundation.org; jasowang@redhat.com; linux- > kernel@vger.kernel.org; ohering@suse.com; apw@canonical.com; > devel@linuxdriverproject.org > Subject: Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT > from the basic I/O timeout > > On Thu, Jul 17, 2014 at 11:53:33PM +0000, KY Srinivasan wrote: > > I still see this problem. There was talk of fixing it elsewhere. > > Well, what we have right not is entirely broken, given that the block layer > doesn't initialize ->timeout on TYPE_FS requeuests. > > We either need to revert that initial commit or apply something like the > attached patch as a quick fix. I had sent this exact patch sometime back: http://www.spinics.net/lists/linux-scsi/msg75385.html K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/