Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932459AbaGRU7y (ORCPT ); Fri, 18 Jul 2014 16:59:54 -0400 Received: from mail-qa0-f54.google.com ([209.85.216.54]:39465 "EHLO mail-qa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755235AbaGRU7x (ORCPT ); Fri, 18 Jul 2014 16:59:53 -0400 Date: Fri, 18 Jul 2014 16:59:50 -0400 (EDT) From: Nicolas Pitre To: Steven Rostedt cc: Ingo Molnar , Daniel Lezcano , Russell King - ARM Linux , Catalin Marinas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH 4/4] (RFC) X86: add IPI tracepoints In-Reply-To: <20140718162750.62cbf965@gandalf.local.home> Message-ID: References: <1405660735-13408-1-git-send-email-nicolas.pitre@linaro.org> <1405660735-13408-5-git-send-email-nicolas.pitre@linaro.org> <20140718162750.62cbf965@gandalf.local.home> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Jul 2014, Steven Rostedt wrote: > On Fri, 18 Jul 2014 01:18:55 -0400 > Nicolas Pitre wrote: > > > > diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c > > index be8e1bde07..e154d176cf 100644 > > --- a/arch/x86/kernel/smp.c > > +++ b/arch/x86/kernel/smp.c > > @@ -31,6 +31,12 @@ > > #include > > #include > > #include > > + > > +#define CREATE_TRACE_POINTS > > +#undef TRACE_INCLUDE_PATH > > +#undef TRACE_INCLUDE_FILE > > I'm curious to why you added the #undefs. I wouldn't think they were > needed. They are needed because asm/trace/irq_vectors.h included prior that point defines them for itself and that makes the inclusion of trace/events/ipi.h fail. > -- Steve > > > +#include > > + > > /* > > * Some notes on x86 processor bugs affecting SMP operation: > > * > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/