Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752079AbaGSFU7 (ORCPT ); Sat, 19 Jul 2014 01:20:59 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:48267 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbaGSFU6 (ORCPT ); Sat, 19 Jul 2014 01:20:58 -0400 Message-ID: <1405747256.605.36.camel@jarvis.lan> Subject: Re: [PATCH] parisc: Remove FIXME comment From: James Bottomley To: Nick Krause Cc: deller@gmx.de, tiwai@suse.de, Jiri Kosina , Joe Perches , dave.anglin@bell.net, linux-parisc@vger.kernel.org, "linux-kernel@vger.kernel.org" Date: Fri, 18 Jul 2014 22:20:56 -0700 In-Reply-To: References: <1405715823-17492-1-git-send-email-xerofoify@gmail.com> <1405717414.30262.12.camel@dabdike.int.hansenpartnership.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-07-18 at 22:25 -0400, Nick Krause wrote: > On Fri, Jul 18, 2014 at 5:03 PM, James Bottomley > wrote: > > On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause wrote: > >> The comment for size of frame not being needed is incorrect , the > >> function called needs this parameter. > > > > Actually, that's not correct. The point of the FIXME is that fram_size > > is only used in a debug print and could be eliminated since the > > internals of the function excluding the debugging statements don't use > > it. > > > > James > > > > > > So I need to need a patch removing the parameter from the function > and this part of the code? Well, no, I'm not sure there's any action to take. The FIXME reminds us that there's no actual use of the frame size in the function body except for the debugging prints. The parameter could be removed if everyone who debugs the kernel agrees either to remove the debug code or remove the frame pointer from the prints, but it's probably not worth bothering about, which is why it's still there. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/