Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761474AbaGSLcH (ORCPT ); Sat, 19 Jul 2014 07:32:07 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:61483 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760830AbaGSLcF (ORCPT ); Sat, 19 Jul 2014 07:32:05 -0400 Date: Sat, 19 Jul 2014 17:01:57 +0530 From: Himangi Saraogi To: Jeff Dike , Richard Weinberger , user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: Julia Lawall Subject: [PATCH] UML: Eliminate NULL test after alloc_bootmem_low_pages Message-ID: <20140719113157.GA23517@himangi-Dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org alloc_bootmem and related functions never return NULL. Thus a NULL test after calls to these functions is unnecessary. The following Coccinelle semantic patch was used for making the change: @@ expression E; statement S; @@ E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...) ... when != E - if (E == NULL) S Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- arch/um/kernel/physmem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/um/kernel/physmem.c b/arch/um/kernel/physmem.c index 30fdd5d..fb041cf 100644 --- a/arch/um/kernel/physmem.c +++ b/arch/um/kernel/physmem.c @@ -43,8 +43,6 @@ int __init init_maps(unsigned long physmem, unsigned long iomem, total_len = phys_len + iomem_len + highmem_len; map = alloc_bootmem_low_pages(total_len); - if (map == NULL) - return -ENOMEM; for (i = 0; i < total_pages; i++) { p = &map[i]; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/