Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755063AbaGSNyV (ORCPT ); Sat, 19 Jul 2014 09:54:21 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:36569 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751828AbaGSNyU (ORCPT ); Sat, 19 Jul 2014 09:54:20 -0400 Date: Sat, 19 Jul 2014 15:54:17 +0200 From: Frederic Weisbecker To: Peter Zijlstra Cc: LKML , Ingo Molnar , "Paul E. McKenney" , Steven Rostedt , Thomas Gleixner , Viresh Kumar Subject: Re: [PATCH 02/10] nohz: Kick full dynticks timer targets with an empty IPI Message-ID: <20140719135415.GB16673@localhost.localdomain> References: <1405730661-9355-1-git-send-email-fweisbec@gmail.com> <1405730661-9355-3-git-send-email-fweisbec@gmail.com> <20140719071951.GS9918@twins.programming.kicks-ass.net> <20140719131844.GA16673@localhost.localdomain> <20140719134741.GH3935@laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140719134741.GH3935@laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 19, 2014 at 03:47:41PM +0200, Peter Zijlstra wrote: > On Sat, Jul 19, 2014 at 03:18:47PM +0200, Frederic Weisbecker wrote: > > On Sat, Jul 19, 2014 at 09:19:51AM +0200, Peter Zijlstra wrote: > > > On Sat, Jul 19, 2014 at 02:44:13AM +0200, Frederic Weisbecker wrote: > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > > > index 7f3063c..f3e48b8 100644 > > > > --- a/kernel/sched/core.c > > > > +++ b/kernel/sched/core.c > > > > @@ -693,7 +693,7 @@ static bool wake_up_full_nohz_cpu(int cpu) > > > > if (tick_nohz_full_cpu(cpu)) { > > > > if (cpu != smp_processor_id() || > > > > tick_nohz_tick_stopped()) > > > > - tick_nohz_full_kick_cpu(cpu); > > > > + irq_work_void_on(cpu); > > > > > > So no, while the previous function name was descriptive, the new one > > > leave one wondering. > > > > Yeah, I suppose I can wrap that to some new function: tick_nohz_full_reschedule_cpu() > > for example (although that looks a bit like a sched thing). > > > > That said I plan to gather tick stop and tick restart in the same place, in the > > end of the interrupt. So in the end we'll have only one tick_nohz_full_kick_cpu() > > for all kick uses, and this will just wrapp to irq_work_void_on(). > > So there's already kick_all_cpus_sync() in kernel/smp.c, I would suggest > implementing your irq_work_void_on() as kick_cpu() right next to it. Good point! > > And yes, I would suggest also keeping tick_nohz_full_kick_cpu() as a > 'pointless' wrapper purely for 'documentation' value. Ok, granted! Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/