Message-ID: <1405818675.5135.3.camel@joe-AO725>
Subject: Re: [PATCH 1/1] Staging: comedi: 8255.c Missing a blank line fixed
From: Joe Perches <joe@perches.com>
To: Sam Asadi <asadi.samuel@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Sat, 19 Jul 2014 18:11:15 -0700
In-Reply-To: <1405816991-8749-1-git-send-email-asadi.samuel@gmail.com>
References: <1405816991-8749-1-git-send-email-asadi.samuel@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Sun, 2014-07-20 at 03:43 +0300, Sam Asadi wrote:
> A 'Missing a blank line after declarations' issue fixed and also tested
> by 'make M=...'. It seems that after 'unsigned long iobase' declaration
> a blank line is desperately needed.
[]
> diff --git a/drivers/staging/comedi/drivers/8255.c b/drivers/staging/comedi/drivers/8255.c
[]
> @@ -94,6 +94,7 @@ I/O port base address can be found in the output of 'lspci -v'.
>  
>  struct subdev_8255_private {
>  	unsigned long iobase;
> +
>  	int (*io)(int, int, int, unsigned long);
>  };
>  

You used an old version of checkpatch without a
modification to the "blank line after declarations"
test that supports function pointers.

Use the latest version from --next instead.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/