Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751549AbaGTVbs (ORCPT ); Sun, 20 Jul 2014 17:31:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58980 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbaGTVbr (ORCPT ); Sun, 20 Jul 2014 17:31:47 -0400 Date: Sun, 20 Jul 2014 23:34:17 +0300 From: "Michael S. Tsirkin" To: Jason Wang Cc: rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next V2 0/3] rx busy polling support for virtio-net Message-ID: <20140720203417.GF2536@redhat.com> References: <1405491707-22706-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405491707-22706-1-git-send-email-jasowang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 16, 2014 at 02:21:44PM +0800, Jason Wang wrote: > Hi all: > > This series introduces the support for rx busy polling support. This > was useful for reduing the latency for a kvm guest. Patch 1-2 > introduces helpers which is used for rx busy polling. Patch 3 > implement the main function. > > Test was done between a kvm guest and an external host. Two hosts were > connected through 40gb mlx4 cards. With both busy_poll and busy_read are > set to 50 in guest, 1 byte netperf tcp_rr shows 116% improvement: > transaction rate was increased from 9151.94 to 19787.37. > > Changes from V1: > - split the patch info smaller ones > - add more details about test setup/configuration > > Please review. Generally I think we should let host know we are polling. For example, kick the rq or something. Or maybe add another io address. Something like this would need a new feature flag though, so I'm fine with just polling in guest until that is available. > Jason Wang (3): > virtio-net: introduce helpers to enable and disable all NAPIs > virtio-net: introduce virtnet_receive() > virtio-net: rx busy polling support > > drivers/net/virtio_net.c | 234 ++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 221 insertions(+), 13 deletions(-) > > -- > 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/