Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752585AbaGUCuW (ORCPT ); Sun, 20 Jul 2014 22:50:22 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:56876 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbaGUCuS (ORCPT ); Sun, 20 Jul 2014 22:50:18 -0400 Message-ID: <1405911010.6083.3.camel@dhcp-9-2-203-236.watson.ibm.com> Subject: Re: [PATCH 4/7] firmware_class: perform new LSM checks From: Mimi Zohar To: James Morris Cc: Kees Cook , LKML , Ming Lei , "Luis R. Rodriguez" , Greg Kroah-Hartman , James Morris , David Howells , "linux-doc@vger.kernel.org" , linux-security-module , linux-firmware@kernel.org, linux-wireless Date: Sun, 20 Jul 2014 22:50:10 -0400 In-Reply-To: References: <1405373897-31671-1-git-send-email-keescook@chromium.org> <1405373897-31671-5-git-send-email-keescook@chromium.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14072102-8236-0000-0000-000003FDE53D Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-07-21 at 09:43 +1000, James Morris wrote: > On Sat, 19 Jul 2014, Kees Cook wrote: > > [...] > > > With the patch series, the LSM hook sees the userspace-touching loads: > > - from kernel built-in: no LSM hook (nonsense to check the static list) > > - direct from filesystem: called with file struct > > - via uevent /sys "loading"/"data" interface: called with NULL file struct > > - via uevent /sys "fd" interface: called with file struct > > Thanks for the overview. Can we get this documented in the LSM code? > > > The reason the "fd" interface was added was because otherwise there's > > no way for systems that use the uevent handler to communicate to the > > kernel where the bytes being shoved into the "data" interface are > > coming from. > > Ok. > > I gather folks have also thought about signing firmware? >From an IMA perspective, this would be the same as for any other file, just a new hook. Mimi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/