Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474AbaGUIDU (ORCPT ); Mon, 21 Jul 2014 04:03:20 -0400 Received: from mail.karo-electronics.de ([81.173.242.67]:62007 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753302AbaGUIDR convert rfc822-to-8bit (ORCPT ); Mon, 21 Jul 2014 04:03:17 -0400 Date: Mon, 21 Jul 2014 10:03:07 +0200 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Cc: Greg Kroah-Hartman , , , Ezequiel Garcia , George Cherian , , Roger Quadros Subject: Re: [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown() Message-ID: <20140721100307.21172b65@ipc1.ka-ro> In-Reply-To: <20140718135713.GH24914@saruman.home> References: <1405675890-8802-1-git-send-email-LW@KARO-electronics.de> <1405675890-8802-2-git-send-email-LW@KARO-electronics.de> <1405675890-8802-3-git-send-email-LW@KARO-electronics.de> <1405675890-8802-4-git-send-email-LW@KARO-electronics.de> <1405675890-8802-5-git-send-email-LW@KARO-electronics.de> <1405675890-8802-6-git-send-email-LW@KARO-electronics.de> <1405675890-8802-7-git-send-email-LW@KARO-electronics.de> <1405675890-8802-8-git-send-email-LW@KARO-electronics.de> <1405675890-8802-9-git-send-email-LW@KARO-electronics.de> <20140718135713.GH24914@saruman.home> Organization: Ka-Ro electronics GmbH X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > On Fri, Jul 18, 2014 at 11:31:29AM +0200, Lothar Waßmann wrote: > > This patch makes it possible to use the musb driver with HW that > > requires external regulators or clocks. > > can you provide an example of such HW ? Are you not using the internal > PHYs ? > The Ka-Ro electronics TX48 module uses the mmc0_clk pin as VBUSEN rathern than usb0_drvvbus. This patch makes it possible to use an external regulator to handle the VBUS switch through the 'vcc-supply' property of the underlying generic_phy device. > > Signed-off-by: Lothar Waßmann > > --- > > drivers/usb/phy/phy-am335x.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c > > index 6522fa7..de25674 100644 > > --- a/drivers/usb/phy/phy-am335x.c > > +++ b/drivers/usb/phy/phy-am335x.c > > @@ -22,6 +22,7 @@ static int am335x_init(struct usb_phy *phy) > > { > > struct am335x_phy *am_phy = dev_get_drvdata(phy->dev); > > > > + usb_gen_phy_init(phy); > > phy_ctrl_power(am_phy->phy_ctrl, am_phy->id, true); > > return 0; > > } > > @@ -31,6 +32,7 @@ static void am335x_shutdown(struct usb_phy *phy) > > struct am335x_phy *am_phy = dev_get_drvdata(phy->dev); > > > > phy_ctrl_power(am_phy->phy_ctrl, am_phy->id, false); > > + usb_gen_phy_shutdown(phy); > > } > > > > static int am335x_phy_probe(struct platform_device *pdev) > > -- > > 1.7.10.4 > > > -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/