Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754800AbaGULRr (ORCPT ); Mon, 21 Jul 2014 07:17:47 -0400 Received: from mail-qg0-f51.google.com ([209.85.192.51]:45245 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754561AbaGULRo (ORCPT ); Mon, 21 Jul 2014 07:17:44 -0400 MIME-Version: 1.0 In-Reply-To: <53C9198B.1020808@imgtec.com> References: <1405413956-2772-1-git-send-email-lftan@altera.com> <1405413956-2772-16-git-send-email-lftan@altera.com> <53C9198B.1020808@imgtec.com> Date: Mon, 21 Jul 2014 19:17:42 +0800 X-Google-Sender-Auth: GEF4b_99Vabq31913htKK1b82gk Message-ID: Subject: Re: [PATCH v2 15/29] nios2: System calls handling From: Ley Foon Tan To: James Hogan Cc: Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , Chung-Lin Tang , Arnd Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 18, 2014 at 8:56 PM, James Hogan wrote: > Hi, > > On 15/07/14 09:45, Ley Foon Tan wrote: >> This patch adds support for system calls from userspaces. It uses the >> asm-generic/unistd.h definitions with architecture spcific syscall. The sys_call_table >> is just an array defined in a C file and it contains pointers to the syscall functions. > > I don't think you need the renameat syscall now that renameat2 exists. > > Can I suggest preceding your patchset with this patch: > https://lkml.org/lkml/2014/4/23/197 > ([RFC 3/3] asm-generic: Drop renameat syscall from default list) > > which drops renameat from the generic list unless __ARCH_WANT_RENAMEAT > is defined in the arch's uapi/asm/unistd.h. Yes, we don't need renameat syscall. Will add this patch. Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/