Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932130AbaGULhX (ORCPT ); Mon, 21 Jul 2014 07:37:23 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:36460 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754157AbaGULhU (ORCPT ); Mon, 21 Jul 2014 07:37:20 -0400 Date: Mon, 21 Jul 2014 04:36:53 -0700 From: Christoph Hellwig To: Boaz Harrosh Cc: Paul Bolle , Al Viro , Christoph Hellwig , Borislav Petkov , Sam Ravnborg , pramod.gurav.etc@gmail.com, Jason Cooper , Markus Mayer , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] direct-io: fix uninitialized warning in do_direct_IO() Message-ID: <20140721113653.GC2628@infradead.org> References: <1404452632-10912-1-git-send-email-pramod.gurav.etc@gmail.com> <20140713115022.GA6054@infradead.org> <53C6B199.2070606@gmail.com> <20140716175803.GA3631@infradead.org> <1405536124.4357.17.camel@x41> <53C79949.7010201@gmail.com> <53C7AF58.5030807@gmail.com> <1405596599.5735.11.camel@x41> <53CB8730.40607@plexistor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53CB8730.40607@plexistor.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good to me, Reviewed-by: Christoph Hellwig While it looks obvious, did you make sure it passes xfstests, which has a lot of direct I/O tests? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/