Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932164AbaGUMK3 (ORCPT ); Mon, 21 Jul 2014 08:10:29 -0400 Received: from mail-qg0-f42.google.com ([209.85.192.42]:65218 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932122AbaGUMK1 (ORCPT ); Mon, 21 Jul 2014 08:10:27 -0400 From: Jeff Layton X-Google-Original-From: Jeff Layton Date: Mon, 21 Jul 2014 08:10:24 -0400 To: Vasily Averin Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Weinberger Subject: Re: [PATCH v4] fs: umount on symlink leaks mnt count Message-ID: <20140721081024.27b00560@tlielax.poochiereds.net> In-Reply-To: <53CCCF9F.6090301@parallels.com> References: <53CCCF9F.6090301@parallels.com> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.22; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Jul 2014 12:30:23 +0400 Vasily Averin wrote: > v4: description corrected > v3: patch inline > > Currently umount on symlink blocks following umount: > > /vz is separate mount > > # ls /vz/ -al | grep test > drwxr-xr-x. 2 root root 4096 Jul 19 01:14 testdir > lrwxrwxrwx. 1 root root 11 Jul 19 01:16 testlink -> /vz/testdir > # umount -l /vz/testlink > umount: /vz/testlink: not mounted (expected) > > # lsof /vz > # umount /vz > umount: /vz: device is busy. (unexpected) > > In this case mountpoint_last() gets an extra refcount on path->mnt > > Signed-off-by: Vasily Averin > --- > fs/namei.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/fs/namei.c b/fs/namei.c > index 985c6f3..9eb787e 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -2256,9 +2256,10 @@ done: > goto out; > } > path->dentry = dentry; > - path->mnt = mntget(nd->path.mnt); > + path->mnt = nd->path.mnt; > if (should_follow_link(dentry, nd->flags & LOOKUP_FOLLOW)) > return 1; > + mntget(path->mnt); > follow_mount(path); > error = 0; > out: Looks correct, I think... Acked-by: -- Jeff Layton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/