Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933328AbaGURmF (ORCPT ); Mon, 21 Jul 2014 13:42:05 -0400 Received: from mail-vc0-f179.google.com ([209.85.220.179]:33620 "EHLO mail-vc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933046AbaGURmD (ORCPT ); Mon, 21 Jul 2014 13:42:03 -0400 MIME-Version: 1.0 In-Reply-To: <20140721091445.1ee700bb@thirdoffive.cmf.nrl.navy.mil> References: <20140721091445.1ee700bb@thirdoffive.cmf.nrl.navy.mil> Date: Mon, 21 Jul 2014 13:42:01 -0400 Message-ID: Subject: Re: solos-pci.c: Fix me From: Nick Krause To: chas williams - CONTRACTOR Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 21, 2014 at 9:14 AM, chas williams - CONTRACTOR wrote: > On Sun, 20 Jul 2014 00:59:42 -0400 > Nick Krause wrote: > >> Hey Chas, >> There seems to be a fix me in this file in the function, solos_bh. >> Is the default statement correct and I remove the fix me or >> does it need to be rewritten. >> Cheers Nick >> > > I am afraid that I don't know enough about the solos hardware to know > if it needs to be rewritten. I gather the solos returns at least three > kinds of packets, data, status and command. If you wish to eliminate > the FIXME comment, you could just write: > > @@ -850,8 +850,7 @@ static void solos_bh(unsigned long card_arg) > dev_kfree_skb_any(skb); > break; > > - case PKT_COMMAND: > - default: /* FIXME: Not really, surely? */ > + default: /* PKT_COMMAND */ > if (process_command(card, port, skb)) > break;power > spin_lock(&card->cli_queue_lock); > > and be done with it since that will preserve existing behavior. My only question then is this function causing bugs as is? Cheers Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/