Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933467AbaGUSTP (ORCPT ); Mon, 21 Jul 2014 14:19:15 -0400 Received: from hedwig.cmf.nrl.navy.mil ([134.207.12.162]:55117 "EHLO hedwig.cmf.nrl.navy.mil" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932320AbaGUSTN (ORCPT ); Mon, 21 Jul 2014 14:19:13 -0400 Date: Mon, 21 Jul 2014 14:18:51 -0400 From: chas williams - CONTRACTOR To: Nick Krause Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: solos-pci.c: Fix me Message-ID: <20140721141851.7f270f4c@thirdoffive.cmf.nrl.navy.mil> In-Reply-To: References: <20140721091445.1ee700bb@thirdoffive.cmf.nrl.navy.mil> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-NRLCMF-Spam-Score: () hits=-0.001 X-NRLCMF-Virus-Scanned: No virus found X-NRLCMF-Languages: en Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Jul 2014 13:42:01 -0400 Nick Krause wrote: > On Mon, Jul 21, 2014 at 9:14 AM, chas williams - CONTRACTOR > wrote: ... > > @@ -850,8 +850,7 @@ static void solos_bh(unsigned long card_arg) > > dev_kfree_skb_any(skb); > > break; > > > > - case PKT_COMMAND: > > - default: /* FIXME: Not really, surely? */ > > + default: /* PKT_COMMAND */ > > if (process_command(card, port, skb)) > > break;power > > spin_lock(&card->cli_queue_lock); > > > > and be done with it since that will preserve existing behavior. > > > My only question then is this function causing bugs as is? > Cheers Nick > It has been there since the first version of this driver was released. If it were breaking things, I would have to guess it would have been noticed by now. Just looking at the PKT_* defines, I would wildly guess that PKT_COMMAND PKT_POPEN and PKT_PCLOSE are all being handled via the PKT_COMMAND|default case. If not, popen and pclose would be leaking a skb for each usage (which would be opening and closing the PVC -- not very often). popen and pclose just seem like specialized PKT_COMMAND types. process_command() woud ignore PKT_POPEN and PKT_PCLOSE since they aren't long enough to contain a command. So maybe the comment should just go away. If you had access to hardware you could probably figure this out pretty quickly. The programmer's manual doesn't seem to be available. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/