Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751228AbaGUWzI (ORCPT ); Mon, 21 Jul 2014 18:55:08 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:61687 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750889AbaGUWzG (ORCPT ); Mon, 21 Jul 2014 18:55:06 -0400 Date: Mon, 21 Jul 2014 18:54:59 -0400 From: Steven Rostedt To: Nicolas Pitre Cc: Ingo Molnar , Daniel Lezcano , Russell King - ARM Linux , Catalin Marinas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH 4/4] (RFC) X86: add IPI tracepoints Message-ID: <20140721185459.54c81bd5@gandalf.local.home> In-Reply-To: References: <1405660735-13408-1-git-send-email-nicolas.pitre@linaro.org> <1405660735-13408-5-git-send-email-nicolas.pitre@linaro.org> <20140718162750.62cbf965@gandalf.local.home> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Jul 2014 16:59:50 -0400 (EDT) Nicolas Pitre wrote: > On Fri, 18 Jul 2014, Steven Rostedt wrote: > > > On Fri, 18 Jul 2014 01:18:55 -0400 > > Nicolas Pitre wrote: > > > > > > > diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c > > > index be8e1bde07..e154d176cf 100644 > > > --- a/arch/x86/kernel/smp.c > > > +++ b/arch/x86/kernel/smp.c > > > @@ -31,6 +31,12 @@ > > > #include > > > #include > > > #include > > > + > > > +#define CREATE_TRACE_POINTS > > > +#undef TRACE_INCLUDE_PATH > > > +#undef TRACE_INCLUDE_FILE > > > > I'm curious to why you added the #undefs. I wouldn't think they were > > needed. > > They are needed because asm/trace/irq_vectors.h included prior that > point defines them for itself and that makes the inclusion of > trace/events/ipi.h fail. > Bah, I tried to get rid of the need for those, but it seems that the macro magic is getting a bit out of hand. I need a new macro magic hat :-p What you got here will have to do. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/