Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754759AbaGVMIV (ORCPT ); Tue, 22 Jul 2014 08:08:21 -0400 Received: from mail-ie0-f178.google.com ([209.85.223.178]:56999 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893AbaGVMIU (ORCPT ); Tue, 22 Jul 2014 08:08:20 -0400 Date: Tue, 22 Jul 2014 13:08:14 +0100 From: Lee Jones To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sameo@linux.intel.com Subject: Re: [PATCH 03/19] mfd: tps80031: Fix 'missing break or fall-through comment' warning Message-ID: <20140722120814.GA16065@lee--X1> References: <1406027485-15657-1-git-send-email-lee.jones@linaro.org> <1406027485-15657-4-git-send-email-lee.jones@linaro.org> <5230900.iFlbGceLXl@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5230900.iFlbGceLXl@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Jul 2014, Arnd Bergmann wrote: > On Tuesday 22 July 2014 12:11:09 Lee Jones wrote: > > --- a/drivers/mfd/tps80031.c > > +++ b/drivers/mfd/tps80031.c > > @@ -334,6 +334,7 @@ static bool rd_wr_reg_id1(struct device *dev, unsigned int reg) > > case TPS80031_PREQ1_RES_ASS_A ... TPS80031_PREQ3_RES_ASS_C: > > case TPS80031_SMPS_OFFSET ... TPS80031_BATDEBOUNCING: > > case TPS80031_CFG_INPUT_PUPD1 ... TPS80031_CFG_SMPS_PD: > > + /* Fall through */ > > case TPS80031_BACKUP_REG: > > return true; > > default: > > This one seems to make the code look worse: You are only adding the comment > to one case, not all of them, and it was perfectly understandable > before. > > Further, there are a couple of other functions following this one that > also don't have that comment. > > It seems checkpatch missed all the other cases because they contain '...' > lists, whereas the one above does not. I think it's better left alone. You're right. I forgot to remove this patch from the set. Please see: https://lkml.org/lkml/2014/7/21/223 -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/