Date: Tue, 22 Jul 2014 15:06:56 -0700 (PDT)
From: David Rientjes <rientjes@google.com>
To: Nicholas Krause <xerofoify@gmail.com>
cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
        gleb@kernel.org, pbonzini@redhat.com, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Subject: Re: [PATCH] x86: Remove Fix me in main.c and add include statement
 for kvm_para.h
In-Reply-To: <1406065658-3866-1-git-send-email-xerofoify@gmail.com>
Message-ID: <alpine.DEB.2.02.1407221506240.5814@chino.kir.corp.google.com>
References: <1406065658-3866-1-git-send-email-xerofoify@gmail.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 22 Jul 2014, Nicholas Krause wrote:

> This patch removes a fix me by including linux/types.h in kvm_para.h
> as stated by the  fix me in main.c and also removes the comment from
> main.c too.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/x86/kernel/cpu/mtrr/main.c | 2 +-
>  include/linux/kvm_para.h        | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
> index f961de9..7ba314b 100644
> --- a/arch/x86/kernel/cpu/mtrr/main.c
> +++ b/arch/x86/kernel/cpu/mtrr/main.c
> @@ -33,7 +33,7 @@
>  
>  #define DEBUG
>  
> -#include <linux/types.h> /* FIXME: kvm_para.h needs this */
> +#include <linux/types.h>
>  
>  #include <linux/stop_machine.h>
>  #include <linux/kvm_para.h>
> diff --git a/include/linux/kvm_para.h b/include/linux/kvm_para.h
> index 00a97bb..21d1be2 100644
> --- a/include/linux/kvm_para.h
> +++ b/include/linux/kvm_para.h
> @@ -2,8 +2,7 @@
>  #define __LINUX_KVM_PARA_H
>  
>  #include <uapi/linux/kvm_para.h>
> -
> -
> +#include <linux/types.h>
>  static inline int kvm_para_has_feature(unsigned int feature)
>  {
>  	if (kvm_arch_para_features() & (1UL << feature))

There's no build error reported that would indicate that this is needed, 
so this patch isn't justifiable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/