Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757185AbaGVWSx (ORCPT ); Tue, 22 Jul 2014 18:18:53 -0400 Received: from mail-vc0-f177.google.com ([209.85.220.177]:61001 "EHLO mail-vc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757077AbaGVWSv (ORCPT ); Tue, 22 Jul 2014 18:18:51 -0400 MIME-Version: 1.0 In-Reply-To: References: <1406065658-3866-1-git-send-email-xerofoify@gmail.com> Date: Tue, 22 Jul 2014 18:18:50 -0400 Message-ID: Subject: Re: [PATCH] x86: Remove Fix me in main.c and add include statement for kvm_para.h From: Nick Krause To: David Rientjes Cc: Thomas Gleixner , mingo@redhat.com, hpa@zytor.com, x86@kernel.org, gleb@kernel.org, pbonzini@redhat.com, "linux-kernel@vger.kernel.org" , kvm@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 22, 2014 at 6:13 PM, David Rientjes wrote: > On Tue, 22 Jul 2014, Nick Krause wrote: > >> >> This patch removes a fix me by including linux/types.h in kvm_para.h >> >> as stated by the fix me in main.c and also removes the comment from >> >> main.c too. >> >> >> >> Signed-off-by: Nicholas Krause >> >> --- >> >> arch/x86/kernel/cpu/mtrr/main.c | 2 +- >> >> include/linux/kvm_para.h | 3 +-- >> >> 2 files changed, 2 insertions(+), 3 deletions(-) >> >> >> >> diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c >> >> index f961de9..7ba314b 100644 >> >> --- a/arch/x86/kernel/cpu/mtrr/main.c >> >> +++ b/arch/x86/kernel/cpu/mtrr/main.c >> >> @@ -33,7 +33,7 @@ >> >> >> >> #define DEBUG >> >> >> >> -#include /* FIXME: kvm_para.h needs this */ >> >> +#include >> >> >> >> #include >> >> #include >> >> diff --git a/include/linux/kvm_para.h b/include/linux/kvm_para.h >> >> index 00a97bb..21d1be2 100644 >> >> --- a/include/linux/kvm_para.h >> >> +++ b/include/linux/kvm_para.h >> >> @@ -2,8 +2,7 @@ >> >> #define __LINUX_KVM_PARA_H >> >> >> >> #include >> >> - >> >> - >> >> +#include >> >> static inline int kvm_para_has_feature(unsigned int feature) >> >> { >> >> if (kvm_arch_para_features() & (1UL << feature)) >> > >> > There's no build error reported that would indicate that this is needed, >> > so this patch isn't justifiable. >> >> >> David, >> >> Good to hear a nicer reply after my stupid patch with page shifts. >> Would you like me to send in a patch that removes this fix me >> then? > > The comment is not the only thing that can be removed in the above patch. > If you test the change and can prove why it's not needed in the changelog, > then such a patch would be worthwhile. I will rewrite this patch removing the comment and explain why. Sounds good or should I remove this file too? Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/