Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933954AbaGVW5Q (ORCPT ); Tue, 22 Jul 2014 18:57:16 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:42282 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932233AbaGVW5M (ORCPT ); Tue, 22 Jul 2014 18:57:12 -0400 Date: Tue, 22 Jul 2014 16:57:08 -0600 From: Bjorn Helgaas To: Murali Karicheri Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King , Grant Likely , Rob Herring , Mohit Kumar , Jingoo Han , Pratyush Anand , Richard Zhu , Kishon Vijay Abraham I , Marek Vasut , Arnd Bergmann , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap Subject: Re: [PATCH v7 0/5] Add Keystone PCIe controller driver Message-ID: <20140722225708.GB27965@google.com> References: <1405961925-27248-1-git-send-email-m-karicheri2@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405961925-27248-1-git-send-email-m-karicheri2@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 21, 2014 at 12:58:40PM -0400, Murali Karicheri wrote: > This patch series add PCIe controller driver for keystone SoCs. This is > based on v4 of the series posted to the mailing list. Keystone PCI controller > is based on version 3.65 of the DW hardware. This driver uses the DW core > functions to implement the PCI controller driver for keystone. > > Testing: > ======= > > Testing of the driver is done on TI's K2HK EVM inserted to a Elma blu!eco > MicroTCA chassis AMC slot with JumpGen SEM-200 AMC SATA Storage and Dual > Ethernet Card Express inserted on another AMC slot. The e1000e driver available > on intel's website is patched to the kernel source tree and build. e1000e.ko > is dynamically loaded and executed ping and iperf tests to test the > functionality. > > Thanks to all of you who have contributed by reviewing and offering valuable > comments. If you want me to add your "Reviewed-by", please let me know so that > I can add it to the commit log and re-send. Patch 1-3 has Acks from maintainers > and I believe this can be merged to upstream branch. Patch 4 is waiting for > Ack from DT maintainer. Please provide the same at the earliest. > > Thanks > > Signed-off-by: Murali Karicheri > > CC: Russell King > CC: Grant Likely > CC: Rob Herring > CC: Mohit Kumar > CC: Jingoo Han > CC: Bjorn Helgaas > CC: Pratyush Anand > CC: Richard Zhu > CC: Kishon Vijay Abraham I > CC: Marek Vasut > CC: Arnd Bergmann > CC: Pawel Moll > CC: Mark Rutland > CC: Ian Campbell > CC: Kumar Gala > CC: Randy Dunlap > CC: Grant Likely > > Changelog: > > v7 > - Removed ti,enable_linktrain DT property. The driver now check if > the link is up and then retrain the link if not already up. This > is as per comment from DT maintainer. > - Rebased to upstream kernel v3.16-rc6 > > v6 > - Added Ack from Maintainer for patch 3. Patch 1-3 now have the > Acks from maintainer and can be merged to upstream branch. > Patch 4 is waiting ack from DT maintainer. > v5 > - Rebased to upstream kernel v3.16-rc5 > - Reworked Patch 3/6 and 4/6 into a single patch based on > maintainer comment to use a API callback model to support > the v3.65 h/w. > v4 > - Addressed comments against 5/5. > - Added a patch 6/6 for Maintainer information > - Added couple of Acked-By: > - Rebased to latest Linux 3.16-rc4 > v3 > - DW application register handling code is now part of > Keystone PCI driver. RFC had this code part of Keystone > PCI driver, then V1 moved this to a separate file to > re-use on other platforms that uses this version of the > DW h/w. Then based on comments against v2, this is moved > back to Keystone driver. > - Keystone SerDes phy driver is removed from this series so that > this can be merged independent of that patch > - added msi_set_irq()/clear_irq() API's to support Keystone > > V2 > - Split the designware pcie enhancement patch to multiple > patches based on functionality added > - Remove the quirk code and add a patch to fix mps/mrss > tuning for ARM. Use kernel command line parameter > pci=pcie_bus_perf to work with Keystone PCI Controller. > Following patch addressed this. > [PATCH v1] ARM: pci: add call to pcie_bus_configure_settings() > - Add documentation for device tree bindings > - Add separate interrupt controller nodes for MSI and Legacy > IRQs and use irq map for legacy IRQ > - Use compatibility to identify v3.65 version of the DW hardware > and use it to customize the designware common code. > - Use reg property for configuration space instead of range > - Other minor updates based on code inspection. > > V1 > - Add an interrupt controller node for Legacy irq chip and use > interrupt map/map-mask property to map legacy IRQs A/B/C/D > - Add a Phy driver to replace the original serdes driver > - Move common application register handling code to a separate > file to allow re-use across other platforms that use older > DW PCIe h/w > - PCI quirk for maximum read request size. Check and override only > if the maximum is higher than what controller can handle. > - Converted to a module platform driver. > > Murali Karicheri (5): > PCI: designware: add rd[wr]_other_conf API > PCI: designware: refactor MSI code to work with v3.65 dw hardware I applied the above two to my pci/host-designware branch. The rest didn't apply cleanly because I applied Kishon's DRA7xx changes first, and there are several conflicts. Can you rebase the rest of them on top of pci/host-designware? > PCI: designware: enhance dw_pcie_host_init() to support v3.65 DW > hardware > PCI: add PCI controller for keystone PCIe h/w > PCI: keystone: Update maintainer information You can squash the MAINTAINERS update into the driver addition. They're logically part of the same change. Bjorn > .../devicetree/bindings/pci/pci-keystone.txt | 68 +++ > MAINTAINERS | 7 + > drivers/pci/host/Kconfig | 5 + > drivers/pci/host/Makefile | 1 + > drivers/pci/host/pci-keystone-dw.c | 521 ++++++++++++++++++++ > drivers/pci/host/pci-keystone.c | 386 +++++++++++++++ > drivers/pci/host/pci-keystone.h | 58 +++ > drivers/pci/host/pcie-designware.c | 116 +++-- > drivers/pci/host/pcie-designware.h | 9 + > 9 files changed, 1135 insertions(+), 36 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pci/pci-keystone.txt > create mode 100644 drivers/pci/host/pci-keystone-dw.c > create mode 100644 drivers/pci/host/pci-keystone.c > create mode 100644 drivers/pci/host/pci-keystone.h > > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/