Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756699AbaGWDYu (ORCPT ); Tue, 22 Jul 2014 23:24:50 -0400 Received: from mail-vc0-f178.google.com ([209.85.220.178]:62464 "EHLO mail-vc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755259AbaGWDYs (ORCPT ); Tue, 22 Jul 2014 23:24:48 -0400 MIME-Version: 1.0 In-Reply-To: <53CF0550.2040309@kernel.org> References: <1405704880-10036-1-git-send-email-xerofoify@gmail.com> <53C9D997.7000409@kernel.org> <53CF0550.2040309@kernel.org> Date: Tue, 22 Jul 2014 23:24:47 -0400 Message-ID: Subject: Re: [PATCH] usb-core: Remove Fix mes in file hcd.c From: Nick Krause To: Sasha Levin Cc: Greg KH , Alan Stern , mail@beyermatthias.de, hdegoede@redhat.com, dan.j.williams@intel.com, valentine.barshak@cogentembedded.com, Ming Lei , Michael Opdenacker , linux-usb@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 22, 2014 at 8:44 PM, Sasha Levin wrote: > On 07/18/2014 10:52 PM, Nick Krause wrote: >> On Fri, Jul 18, 2014 at 10:45 PM, Nick Krause wrote: >>> Sorry didn't run spell check. I will resend this patch with the >>> correct information >>> as needed. Thanks for the advice, Sasha. >>> >>> Cheers Nick >>> >>> On Fri, Jul 18, 2014 at 10:36 PM, Sasha Levin wrote: >>>> On 07/18/2014 01:34 PM, Nicholas Krause wrote: >>>>> I am removing two fix mes in this file as after dicussing then it seems >>>>> there is no reason to check against Null for usb_device as it can never >>>>> be NULL and this is check is therefore not needed. >>>>> >>>>> Signed-off-by: Nicholas Krause >>>> >>>> Please explain exactly why it's not needed, why it can never be NULL, and >>>> what prevents it from being NULL. >>>> >>>> "after dicussing" (do you run spellcheck on your mails?) won't mean anything >>>> to someone looking at this commit in a year. >>>> >>>> Your commit message also mentions usb_device which has nothing to do with >>>> your patch. >>>> >>>> >>>> Thanks, >>>> Sasha >> >> Sasha , >> Greg seems to have signed it off. >> Cheers Nick > > Greg? > > Even if the patch is correct (and I'm not saying it is) the commit message is way off. > > > Thanks, > Sasha Sasha, The patch is in the kernel now. I am not going through the trouble of removing it, if you want to fix the commit message go on ahead. Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/