Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758211AbaGWP1Z (ORCPT ); Wed, 23 Jul 2014 11:27:25 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:35879 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758019AbaGWP1X (ORCPT ); Wed, 23 Jul 2014 11:27:23 -0400 MIME-Version: 1.0 In-Reply-To: <1405610748-7583-3-git-send-email-iivanov@mm-sol.com> References: <1405610748-7583-1-git-send-email-iivanov@mm-sol.com> <1405610748-7583-3-git-send-email-iivanov@mm-sol.com> Date: Wed, 23 Jul 2014 17:27:22 +0200 Message-ID: Subject: Re: [PATCH v2 2/4] pinctrl: qpnp: Qualcomm PMIC pin controller driver From: Linus Walleij To: "Ivan T. Ivanov" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Bjorn Andersson , Mark Brown , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 17, 2014 at 5:25 PM, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > This is the pinctrl, pinmux, pinconf and gpiolib driver for the > Qualcomm GPIO and MPP sub-function blocks found in the PMIC chips. > > Signed-off-by: Ivan T. Ivanov (...) > +static int qpnp_pinctrl_remove(struct platform_device *pdev) > +{ > + struct qpnp_pinctrl *qctrl = platform_get_drvdata(pdev); > + > + pinctrl_unregister(qctrl->ctrl); > + > + return gpiochip_remove(&qctrl->chip); We're removing the return value from gpiochip_remove() and I have dropped the __must_check attribute today, so just remove it unconditionally and return 0; Sorry for short and lame comment on a large patch I should look closer at, but atleast it's something. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/